From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f69.google.com (mail-wm0-f69.google.com [74.125.82.69]) by kanga.kvack.org (Postfix) with ESMTP id AC538280910 for ; Fri, 10 Mar 2017 07:40:49 -0500 (EST) Received: by mail-wm0-f69.google.com with SMTP id c143so3170409wmd.1 for ; Fri, 10 Mar 2017 04:40:49 -0800 (PST) Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com. [2a00:1450:400c:c0c::244]) by mx.google.com with ESMTPS id v63si2708142wma.38.2017.03.10.04.40.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Mar 2017 04:40:47 -0800 (PST) Received: by mail-wr0-x244.google.com with SMTP id g10so11467557wrg.0 for ; Fri, 10 Mar 2017 04:40:47 -0800 (PST) Date: Fri, 10 Mar 2017 13:40:43 +0100 From: Daniel Vetter Subject: Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging Message-ID: <20170310124043.45hdu64wd4acf4it@phenom.ffwll.local> References: <1488491084-17252-1-git-send-email-labbott@redhat.com> <20170303132949.GC31582@dhcp22.suse.cz> <20170306074258.GA27953@dhcp22.suse.cz> <20170306104041.zghsicrnadoap7lp@phenom.ffwll.local> <20170306105805.jsq44kfxhsvazkm6@sirena.org.uk> <20170306160437.sf7bksorlnw7u372@phenom.ffwll.local> <26bc57ae-d88f-4ea0-d666-2c1a02bf866f@redhat.com> <20170310103112.GA15945@e106950-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170310103112.GA15945@e106950-lin.cambridge.arm.com> Sender: owner-linux-mm@kvack.org List-ID: To: Brian Starkey Cc: Laura Abbott , Benjamin Gaignard , Mark Brown , Michal Hocko , Sumit Semwal , Riley Andrews , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Rom Lemarchand , devel@driverdev.osuosl.org, Linux Kernel Mailing List , "linaro-mm-sig@lists.linaro.org" , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Daniel Vetter , linux-mm@kvack.org On Fri, Mar 10, 2017 at 10:31:13AM +0000, Brian Starkey wrote: > Hi, > > On Thu, Mar 09, 2017 at 09:38:49AM -0800, Laura Abbott wrote: > > On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: > > [snip] > > > > > > > For me those patches are going in the right direction. > > > > > > I still have few questions: > > > - since alignment management has been remove from ion-core, should it > > > be also removed from ioctl structure ? > > > > Yes, I think I'm going to go with the suggestion to fixup the ABI > > so we don't need the compat layer and as part of that I'm also > > dropping the align argument. > > > > Is the only motivation for removing the alignment parameter that > no-one got around to using it for something useful yet? > The original comment was true - different devices do have different > alignment requirements. > > Better alignment can help SMMUs use larger blocks when mapping, > reducing TLB pressure and the chance of a page table walk causing > display underruns. Extending ioctl uapi is easy, trying to get rid of bad uapi is much harder. Given that right now we don't have an ion allocator that does alignment I think removing it makes sense. And if we go with lots of heaps, we might as well have an ion heap per alignment that your hw needs, so there's different ways to implement this in the future. At least from the unix device memory allocator pov it's probably simpler to encode stuff like this into the heap name, instead of having to pass heap + list of additional properties/constraints. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org