From: Herbert Xu <herbert@gondor.apana.org.au>
To: Dan Streetman <ddstreet@ieee.org>
Cc: Mahipal Reddy <mahipalreddy2006@gmail.com>,
Mahipal Challa <Mahipal.Challa@cavium.com>,
Seth Jennings <sjenning@redhat.com>,
Linux-MM <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
pathreya@cavium.com, Vishnu Nair <Vishnu.Nair@cavium.com>
Subject: Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support
Date: Thu, 9 Mar 2017 17:39:54 +0800 [thread overview]
Message-ID: <20170309093954.GA6567@gondor.apana.org.au> (raw)
In-Reply-To: <CALZtONBuQJN3Qrd-RP4_TAD=OeWNO8quPYpN+=Gsz2byAxWFPg@mail.gmail.com>
On Wed, Mar 08, 2017 at 12:38:40PM -0500, Dan Streetman wrote:
>
> It looks like the crypto_scomp interface is buried under
> include/crypto/internal/scompress.h, however that's exactly what zswap
> should be using. We don't need to switch to an asynchronous interface
> that's rather significantly more complicated, and then use it in a
> synchronous way. The crypto_scomp interface should probably be made
> public, not an implementation internal.
No scomp is not meant to be used externally. We provide exactly
one compression interface and it's acomp. acomp can be used
synchronously by setting the CRYPTO_ALG_ASYNC bit in the mask
field when allocating the algorithm.
The existing compression interface will be phased out.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-09 9:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 16:05 [PATCH v2 0/1] mm: zswap - crypto acomp/scomp support Mahipal Challa
2017-02-24 16:05 ` [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support Mahipal Challa
2017-02-24 22:21 ` Dan Streetman
2017-02-27 14:40 ` Mahipal Reddy
2017-03-08 17:38 ` Dan Streetman
2017-03-09 9:39 ` Herbert Xu [this message]
2017-03-16 15:54 ` Dan Streetman
2017-03-16 16:17 ` Herbert Xu
2017-03-16 16:33 ` Herbert Xu
2017-03-16 18:20 ` Dan Streetman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309093954.GA6567@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Mahipal.Challa@cavium.com \
--cc=Vishnu.Nair@cavium.com \
--cc=ddstreet@ieee.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mahipalreddy2006@gmail.com \
--cc=pathreya@cavium.com \
--cc=sjenning@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox