From: Al Viro <viro@ZenIV.linux.org.uk>
To: Lorenzo Stoakes <lstoakes@gmail.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-mm@kvack.org
Subject: Re: [PATCH RESEND] drm/via: use get_user_pages_unlocked()
Date: Tue, 28 Feb 2017 19:35:39 +0000 [thread overview]
Message-ID: <20170228193539.GT29622@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20170228090110.m4pxtjlbgaft7oet@phenom.ffwll.local>
On Tue, Feb 28, 2017 at 10:01:10AM +0100, Daniel Vetter wrote:
> > + ret = get_user_pages_unlocked((unsigned long)xfer->mem_addr,
> > + vsg->num_pages, vsg->pages,
> > + (vsg->direction == DMA_FROM_DEVICE) ? FOLL_WRITE : 0);
Umm... Why not
ret = get_user_pages_fast((unsigned long)xfer->mem_addr,
vsg->num_pages,
vsg->direction == DMA_FROM_DEVICE,
vsg->pages);
IOW, do you really need a warranty that ->mmap_sem will be grabbed and
released?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-02-28 19:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 21:50 Lorenzo Stoakes
2017-02-28 9:01 ` Daniel Vetter
2017-02-28 19:35 ` Al Viro [this message]
2017-02-28 20:28 ` Lorenzo Stoakes
2017-03-01 8:43 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170228193539.GT29622@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox