From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Joonsoo Kim <js1304@gmail.com>,
m.szyprowski@samsung.com
Subject: Re: [PATCH 3/8] mm: cma: Export a few symbols
Date: Mon, 13 Feb 2017 14:44:16 +0100 [thread overview]
Message-ID: <20170213134416.akgmtv3lv5m65fwx@lukather> (raw)
In-Reply-To: <20170209192046.GB31906@dhcp22.suse.cz>
[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]
Hi Michal,
On Thu, Feb 09, 2017 at 08:20:47PM +0100, Michal Hocko wrote:
> [CC CMA people]
>
> On Thu 09-02-17 17:39:17, Maxime Ripard wrote:
> > Modules might want to check their CMA pool size and address for debugging
> > and / or have additional checks.
> >
> > The obvious way to do this would be through dev_get_cma_area and
> > cma_get_base and cma_get_size, that are currently not exported, which
> > results in a build failure.
> >
> > Export them to prevent such a failure.
>
> Who actually uses those exports. None of the follow up patches does
> AFAICS.
This is for the ARM Mali GPU driver that is out of tree, unfortunately.
In one case (using the legacy fbdev API), the driver wants to (and
probably should) validate that the buffer as indeed been allocated
from the memory allocation pool.
Rob suggested that instead of hardcoding it to cover the whole RAM
(which defeats the purpose of that check in the first place), we used
the memory-region bindings in the DT and follow that, which does work
great, but we still have to retrieve the base address and size of that
region, hence why this patches are needed.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-02-13 13:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 16:39 [PATCH 0/8] ARM: sun8i: a33: Mali improvements Maxime Ripard
2017-02-09 16:39 ` [PATCH 1/8] ARM: sun8i: Fix the mali clock rate Maxime Ripard
2017-02-27 14:39 ` Maxime Ripard
2017-02-09 16:39 ` [PATCH 2/8] dt-bindings: gpu: mali: Add optional memory-region Maxime Ripard
2017-02-15 23:37 ` Rob Herring
2017-02-27 14:39 ` Maxime Ripard
2017-02-09 16:39 ` [PATCH 3/8] mm: cma: Export a few symbols Maxime Ripard
2017-02-09 19:20 ` Michal Hocko
2017-02-13 13:44 ` Maxime Ripard [this message]
2017-02-20 12:35 ` Michal Hocko
2017-02-23 22:58 ` Maxime Ripard
2017-02-09 16:39 ` [PATCH 4/8] drm/sun4i: Grab reserved memory region Maxime Ripard
2017-02-27 14:49 ` Maxime Ripard
2017-02-09 16:39 ` [PATCH 5/8] ARM: sun8i: a33: Add shared display memory pool Maxime Ripard
2017-02-09 16:39 ` [PATCH 6/8] dt-bindings: gpu: mali: Add optional OPPs Maxime Ripard
2017-02-15 23:42 ` Rob Herring
2017-02-27 14:39 ` Maxime Ripard
2017-02-09 16:39 ` [PATCH 7/8] ARM: sunxi: Select PM_OPP Maxime Ripard
2017-02-27 14:40 ` Maxime Ripard
2017-02-09 16:39 ` [PATCH 8/8] ARM: sun8i: a33: Add the Mali OPPs Maxime Ripard
2017-02-15 23:40 ` Rob Herring
2017-02-27 14:40 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170213134416.akgmtv3lv5m65fwx@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=js1304@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=mhocko@kernel.org \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox