From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f198.google.com (mail-yw0-f198.google.com [209.85.161.198]) by kanga.kvack.org (Postfix) with ESMTP id BA1166B0038 for ; Fri, 10 Feb 2017 12:53:18 -0500 (EST) Received: by mail-yw0-f198.google.com with SMTP id q71so49134931ywg.1 for ; Fri, 10 Feb 2017 09:53:18 -0800 (PST) Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com. [67.231.145.42]) by mx.google.com with ESMTPS id 205si718815yww.157.2017.02.10.09.53.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Feb 2017 09:53:18 -0800 (PST) Date: Fri, 10 Feb 2017 09:52:33 -0800 From: Shaohua Li Subject: Re: [PATCH V2 6/7] proc: show MADV_FREE pages info in smaps Message-ID: <20170210175232.GE86050@shli-mbp.local> References: <1239fb2871c55d63e7e649ad14c6dabaef131d66.1486163864.git.shli@fb.com> <20170210133040.GN10893@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170210133040.GN10893@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Kernel-team@fb.com, danielmicay@gmail.com, minchan@kernel.org, hughd@google.com, hannes@cmpxchg.org, riel@redhat.com, mgorman@techsingularity.net, akpm@linux-foundation.org On Fri, Feb 10, 2017 at 02:30:40PM +0100, Michal Hocko wrote: > $DESCRIPTION_OF_YOUR_USECASE_GOES_HERE > > Moreover Documentation/filesystems/proc.txt should be updated as well. > > Other than that, the patch looks good to me. Ok, will add more description and add doc for proc.txt. I don't have solid use case for this though. It's consistent with other info we exported to userspace and mostly for diagnosing purpose. Thanks, Shaohua > On Fri 03-02-17 15:33:22, Shaohua Li wrote: > > Cc: Michal Hocko > > Cc: Minchan Kim > > Cc: Hugh Dickins > > Cc: Johannes Weiner > > Cc: Rik van Riel > > Cc: Mel Gorman > > Cc: Andrew Morton > > Signed-off-by: Shaohua Li > > after the description is added and documentation updated > Acked-by: Michal Hocko > > > --- > > fs/proc/task_mmu.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > > index ee3efb2..8f2423f 100644 > > --- a/fs/proc/task_mmu.c > > +++ b/fs/proc/task_mmu.c > > @@ -440,6 +440,7 @@ struct mem_size_stats { > > unsigned long private_dirty; > > unsigned long referenced; > > unsigned long anonymous; > > + unsigned long lazyfree; > > unsigned long anonymous_thp; > > unsigned long shmem_thp; > > unsigned long swap; > > @@ -456,8 +457,11 @@ static void smaps_account(struct mem_size_stats *mss, struct page *page, > > int i, nr = compound ? 1 << compound_order(page) : 1; > > unsigned long size = nr * PAGE_SIZE; > > > > - if (PageAnon(page)) > > + if (PageAnon(page)) { > > mss->anonymous += size; > > + if (!PageSwapBacked(page)) > > + mss->lazyfree += size; > > + } > > > > mss->resident += size; > > /* Accumulate the size in pages that have been accessed. */ > > @@ -770,6 +774,7 @@ static int show_smap(struct seq_file *m, void *v, int is_pid) > > "Private_Dirty: %8lu kB\n" > > "Referenced: %8lu kB\n" > > "Anonymous: %8lu kB\n" > > + "LazyFree: %8lu kB\n" > > "AnonHugePages: %8lu kB\n" > > "ShmemPmdMapped: %8lu kB\n" > > "Shared_Hugetlb: %8lu kB\n" > > @@ -788,6 +793,7 @@ static int show_smap(struct seq_file *m, void *v, int is_pid) > > mss.private_dirty >> 10, > > mss.referenced >> 10, > > mss.anonymous >> 10, > > + mss.lazyfree >> 10, > > mss.anonymous_thp >> 10, > > mss.shmem_thp >> 10, > > mss.shared_hugetlb >> 10, > > -- > > 2.9.3 > > > > -- > Michal Hocko > SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org