From: Michal Hocko <mhocko@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "peter enderborg" <peter.enderborg@sonymobile.com>,
devel@driverdev.osuosl.org,
"Riley Andrews" <riandrews@android.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
"Arve Hjønnevåg" <arve@android.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: [PATCH 1/3 staging-next] android: Collect statistics from lowmemorykiller
Date: Fri, 10 Feb 2017 08:59:49 +0100 [thread overview]
Message-ID: <20170210075949.GB10893@dhcp22.suse.cz> (raw)
In-Reply-To: <20170210075149.GA17166@kroah.com>
On Fri 10-02-17 08:51:49, Greg KH wrote:
> On Fri, Feb 10, 2017 at 08:21:32AM +0100, peter enderborg wrote:
[...]
> > Until then we have to polish this version as good as we can. It is
> > essential for android as it is now.
>
> But if no one is willing to do the work to fix the reported issues, why
> should it remain? Can you do the work here? You're already working on
> fixing some of the issues in a differnt way, why not do the "real work"
> here instead for everyone to benifit from?
Well, to be honest, I do not think that the current code is easily
fixable. The approach was wrong from the day 1. Abusing slab shrinkers
is just a bad place to stick this logic. This all belongs to the
userspace. For that we need a proper mm pressure notification which is
supposed to be vmpressure but that one also doesn't seem to work all
that great. So rather than trying to fix unfixable I would stronly
suggest focusing on making vmpressure work reliably.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-02-10 7:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 13:21 peter enderborg
2017-02-09 13:50 ` Greg Kroah-Hartman
2017-02-09 19:26 ` Michal Hocko
2017-02-09 20:07 ` Greg Kroah-Hartman
2017-02-09 20:54 ` Michal Hocko
2017-02-10 7:21 ` peter enderborg
2017-02-10 7:51 ` Greg Kroah-Hartman
2017-02-10 7:59 ` Michal Hocko [this message]
2017-02-10 9:05 ` peter enderborg
2017-02-10 9:15 ` Michal Hocko
2017-02-13 15:42 ` peter enderborg
2017-02-10 9:05 ` peter enderborg
2017-02-10 10:34 ` Greg Kroah-Hartman
2017-02-14 16:09 peter.enderborg
2017-02-14 16:50 ` Greg KH
2017-02-15 8:22 ` peter enderborg
2017-02-15 14:29 ` Greg KH
2017-02-14 16:51 ` Greg KH
2017-02-15 8:21 ` peter enderborg
2017-02-15 14:31 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210075949.GB10893@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peter.enderborg@sonymobile.com \
--cc=riandrews@android.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox