From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Andrea Arcangeli <aarcange@redhat.com>,
Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: [PATCHv2 10/12] mm: convert page_mapped_in_vma() to page_vma_mapped_walk()
Date: Wed, 25 Jan 2017 21:25:36 +0300 [thread overview]
Message-ID: <20170125182538.86249-11-kirill.shutemov@linux.intel.com> (raw)
In-Reply-To: <20170125182538.86249-1-kirill.shutemov@linux.intel.com>
For consistency, it worth converting all page_check_address() to
page_vma_mapped_walk(), so we could drop the former.
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
mm/page_vma_mapped.c | 30 ++++++++++++++++++++++++++++++
mm/rmap.c | 26 --------------------------
2 files changed, 30 insertions(+), 26 deletions(-)
diff --git a/mm/page_vma_mapped.c b/mm/page_vma_mapped.c
index 63168b4baf19..13929f2418b0 100644
--- a/mm/page_vma_mapped.c
+++ b/mm/page_vma_mapped.c
@@ -179,3 +179,33 @@ next_pte: do {
}
}
}
+
+/**
+ * page_mapped_in_vma - check whether a page is really mapped in a VMA
+ * @page: the page to test
+ * @vma: the VMA to test
+ *
+ * Returns 1 if the page is mapped into the page tables of the VMA, 0
+ * if the page is not mapped into the page tables of this VMA. Only
+ * valid for normal file or anonymous VMAs.
+ */
+int page_mapped_in_vma(struct page *page, struct vm_area_struct *vma)
+{
+ struct page_vma_mapped_walk pvmw = {
+ .page = page,
+ .vma = vma,
+ .flags = PVMW_SYNC,
+ };
+ unsigned long start, end;
+
+ start = __vma_address(page, vma);
+ end = start + PAGE_SIZE * (hpage_nr_pages(page) - 1);
+
+ if (unlikely(end < vma->vm_start || start >= vma->vm_end))
+ return 0;
+ pvmw.address = max(start, vma->vm_start);
+ if (!page_vma_mapped_walk(&pvmw))
+ return 0;
+ page_vma_mapped_walk_done(&pvmw);
+ return 1;
+}
diff --git a/mm/rmap.c b/mm/rmap.c
index 95183dbea2eb..5d5e504c41d8 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -756,32 +756,6 @@ pte_t *__page_check_address(struct page *page, struct mm_struct *mm,
return NULL;
}
-/**
- * page_mapped_in_vma - check whether a page is really mapped in a VMA
- * @page: the page to test
- * @vma: the VMA to test
- *
- * Returns 1 if the page is mapped into the page tables of the VMA, 0
- * if the page is not mapped into the page tables of this VMA. Only
- * valid for normal file or anonymous VMAs.
- */
-int page_mapped_in_vma(struct page *page, struct vm_area_struct *vma)
-{
- unsigned long address;
- pte_t *pte;
- spinlock_t *ptl;
-
- address = __vma_address(page, vma);
- if (unlikely(address < vma->vm_start || address >= vma->vm_end))
- return 0;
- pte = page_check_address(page, vma->vm_mm, address, &ptl, 1);
- if (!pte) /* the page is not in this mm */
- return 0;
- pte_unmap_unlock(pte, ptl);
-
- return 1;
-}
-
#ifdef CONFIG_TRANSPARENT_HUGEPAGE
/*
* Check that @page is mapped at @address into @mm. In contrast to
--
2.11.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-01-25 18:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 18:25 [PATCHv2 00/12] Fix few rmap-related THP bugs Kirill A. Shutemov
2017-01-25 18:25 ` [PATCHv2 01/12] uprobes: split THPs before trying replace them Kirill A. Shutemov
2017-01-25 18:25 ` [PATCHv2 02/12] mm: introduce page_vma_mapped_walk() Kirill A. Shutemov
2017-01-25 20:38 ` Kirill A. Shutemov
2017-01-25 22:42 ` Kirill A. Shutemov
2017-01-25 18:25 ` [PATCHv2 03/12] mm: fix handling PTE-mapped THPs in page_referenced() Kirill A. Shutemov
2017-01-25 18:25 ` [PATCHv2 04/12] mm: fix handling PTE-mapped THPs in page_idle_clear_pte_refs() Kirill A. Shutemov
2017-01-25 18:25 ` [PATCHv2 05/12] mm, rmap: check all VMAs that PTE-mapped THP can be part of Kirill A. Shutemov
2017-01-26 6:56 ` Hillf Danton
2017-01-25 18:25 ` [PATCHv2 06/12] mm: convert page_mkclean_one() to page_vma_mapped_walk() Kirill A. Shutemov
2017-01-25 18:25 ` [PATCHv2 07/12] mm: convert try_to_unmap_one() " Kirill A. Shutemov
2017-01-25 19:02 ` kbuild test robot
2017-01-25 19:05 ` kbuild test robot
2017-01-25 22:46 ` Kirill A. Shutemov
2017-01-25 18:25 ` [PATCHv2 08/12] mm, ksm: convert write_protect_page() " Kirill A. Shutemov
2017-01-25 18:25 ` [PATCHv2 09/12] mm, uprobes: convert __replace_page() " Kirill A. Shutemov
2017-01-25 18:25 ` Kirill A. Shutemov [this message]
2017-01-26 7:31 ` [PATCHv2 10/12] mm: convert page_mapped_in_vma() " Hillf Danton
2017-01-25 18:25 ` [PATCHv2 11/12] mm: drop page_check_address{,_transhuge} Kirill A. Shutemov
2017-01-25 18:25 ` [PATCHv2 12/12] mm: convert remove_migration_pte() to page_vma_mapped_walk() Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125182538.86249-11-kirill.shutemov@linux.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox