From: Leon Romanovsky <leon@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Michal Hocko <mhocko@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check
Date: Mon, 16 Jan 2017 12:09:30 +0200 [thread overview]
Message-ID: <20170116100930.GE32481@mtr-leonro.local> (raw)
In-Reply-To: <20170116095522.lrqcoqktozvoeaql@pd.tnic>
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
On Mon, Jan 16, 2017 at 10:55:22AM +0100, Borislav Petkov wrote:
> On Mon, Jan 16, 2017 at 11:48:51AM +0200, Leon Romanovsky wrote:
> > Almost, except one point - pr_warn and dump_stack have different log
>
> Actually, Michal pointed out on IRC a more relevant difference:
>
> WARN() taints the kernel and we don't want that for GFP flags misuse.
And doesn't dump_stack do the same? It pollutes the log too.
> Also, from looking at __warn(), it checks panic_on_warn and we explode
> if set.
Right, it is very valid point.
>
> So no, we probably don't want WARN() here.
I understand, Thanks.
>
> --
> Regards/Gruss,
> Boris.
>
> Good mailing practices for 400: avoid top-posting and trim the reply.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-01-16 10:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 9:16 Borislav Petkov
2017-01-16 9:28 ` Leon Romanovsky
2017-01-16 9:37 ` Borislav Petkov
2017-01-16 9:48 ` Leon Romanovsky
2017-01-16 9:55 ` Borislav Petkov
2017-01-16 10:09 ` Leon Romanovsky [this message]
2017-01-16 10:13 ` Borislav Petkov
2017-01-16 10:18 ` Leon Romanovsky
2017-01-16 9:59 ` Michal Hocko
2017-01-16 9:38 ` Michal Hocko
2017-01-16 10:08 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116100930.GE32481@mtr-leonro.local \
--to=leon@kernel.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox