From: Christoph Hellwig <hch@infradead.org>
To: David Graziano <david.graziano@rockwellcollins.com>
Cc: linux-security-module@vger.kernel.org, paul@paul-moore.com,
agruenba@redhat.com, hch@infradead.org, linux-mm@kvack.org,
sds@tycho.nsa.gov, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] xattr: add simple initxattrs function
Date: Sun, 8 Jan 2017 01:55:11 -0800 [thread overview]
Message-ID: <20170108095511.GB4203@infradead.org> (raw)
In-Reply-To: <1483653823-22018-2-git-send-email-david.graziano@rockwellcollins.com>
> +/*
> + * Callback for security_inode_init_security() for acquiring xattrs.
> + */
> +int simple_xattr_initxattrs(struct inode *inode,
> + const struct xattr *xattr_array,
> + void *fs_info)
> +{
> + struct simple_xattrs *xattrs;
> + const struct xattr *xattr;
> + struct simple_xattr *new_xattr;
> + size_t len;
> +
> + if (!fs_info)
> + return -ENOMEM;
This probablt should be an EINVAL, and also a WARN_ON_ONCE.
> + xattrs = (struct simple_xattrs *) fs_info;
No need for the cast. In fact we should probably just declarate it
as struct simple_xattrs *xattrs in the protoype and thus be type safe.
> +
> + for (xattr = xattr_array; xattr->name != NULL; xattr++) {
> + new_xattr = simple_xattr_alloc(xattr->value, xattr->value_len);
> + if (!new_xattr)
> + return -ENOMEM;
We'll need to unwind the previous allocations here.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-01-08 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 22:03 [PATCH v4 0/3] initxattr callback update for mqueue xattr support David Graziano
2017-01-05 22:03 ` [PATCH v4 1/3] xattr: add simple initxattrs function David Graziano
2017-01-08 9:55 ` Christoph Hellwig [this message]
2017-01-09 15:41 ` David Graziano
2017-01-05 22:03 ` [PATCH v4 2/3] shmem: use simple initxattrs callback David Graziano
2017-01-05 22:03 ` [PATCH v4 3/3] mqueue: Implement generic xattr support David Graziano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170108095511.GB4203@infradead.org \
--to=hch@infradead.org \
--cc=agruenba@redhat.com \
--cc=david.graziano@rockwellcollins.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox