From: Michal Hocko <mhocko@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: __GFP_REPEAT usage in fq_alloc_node
Date: Fri, 6 Jan 2017 17:19:44 +0100 [thread overview]
Message-ID: <20170106161944.GW5556@dhcp22.suse.cz> (raw)
In-Reply-To: <20170106160743.GU5556@dhcp22.suse.cz>
On Fri 06-01-17 17:07:43, Michal Hocko wrote:
> On Fri 06-01-17 07:39:14, Eric Dumazet wrote:
> > On Fri, Jan 6, 2017 at 7:20 AM, Michal Hocko <mhocko@kernel.org> wrote:
> > >
> > > Hi Eric,
> > > I am currently checking kmalloc with vmalloc fallback users and convert
> > > them to a new kvmalloc helper [1]. While I am adding a support for
> > > __GFP_REPEAT to kvmalloc [2] I was wondering what is the reason to use
> > > __GFP_REPEAT in fq_alloc_node in the first place. c3bd85495aef
> > > ("pkt_sched: fq: more robust memory allocation") doesn't mention
> > > anything. Could you clarify this please?
> > >
> > > Thanks!
> >
> > I guess this question applies to all __GFP_REPEAT usages in net/ ?
>
> I am _currently_ interested only in those which have vmalloc fallback
> and cannot see more of them. Maybe my git grep foo needs some help.
I was obviously blind...
---
next prev parent reply other threads:[~2017-01-06 16:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 15:20 Michal Hocko
2017-01-06 15:37 ` Eric Dumazet
2017-01-06 15:39 ` Eric Dumazet
2017-01-06 16:07 ` Michal Hocko
2017-01-06 16:19 ` Michal Hocko [this message]
2017-01-07 3:33 ` [PATCH] net: use kvmalloc rather than open coded variant kbuild test robot
2017-01-07 9:19 ` Michal Hocko
2017-01-07 3:35 ` kbuild test robot
2017-01-09 10:22 ` __GFP_REPEAT usage in fq_alloc_node Michal Hocko
2017-01-09 16:00 ` Eric Dumazet
2017-01-09 17:45 ` Michal Hocko
2017-01-09 17:53 ` Eric Dumazet
2017-01-14 23:43 ` [PATCH] net_sched: use kvmalloc rather than opencoded variant kbuild test robot
2017-01-16 8:54 ` Michal Hocko
2017-01-06 16:31 ` __GFP_REPEAT usage in fq_alloc_node Vlastimil Babka
2017-01-06 16:48 ` Eric Dumazet
2017-01-06 16:50 ` Eric Dumazet
2017-01-06 16:55 ` Vlastimil Babka
2017-01-06 17:08 ` Eric Dumazet
2017-01-06 17:18 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170106161944.GW5556@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox