On Tue 29-11-16 09:58:31, Wei Fang wrote: > Hi, Jan, > > On 2016/11/28 18:07, Jan Kara wrote: > > Good catch but I don't like sprinkling checks like this into the writeback > > code and furthermore we don't want to call into writeback code when block > > device is in the process of being destroyed which is what would happen with > > your patch. That is a bug waiting to happen... > > Agreed. Need another way to fix this problem. I looked through the > writeback cgroup code in __filemap_fdatawrite_range(), found if we > turn on CONFIG_CGROUP_WRITEBACK, a new crash will happen. OK, can you test with attached patch please? Thanks! Honza -- Jan Kara SUSE Labs, CR