From: Michal Hocko <mhocko@kernel.org>
To: Hui Zhu <zhuhui@xiaomi.com>
Cc: minchan@kernel.org, ngupta@vflare.org,
sergey.senozhatsky.work@gmail.com, dan.j.williams@intel.com,
jthumshirn@suse.de, akpm@linux-foundation.org,
re.emese@gmail.com, andriy.shevchenko@linux.intel.com,
vishal.l.verma@intel.com, hannes@cmpxchg.org,
mgorman@techsingularity.net, vbabka@suse.cz,
vdavydov.dev@gmail.com, kirill.shutemov@linux.intel.com,
ying.huang@intel.com, yang.shi@linaro.org,
dave.hansen@linux.intel.com, willy@linux.intel.com,
vkuznets@redhat.com, vitalywool@gmail.com, jmarchan@redhat.com,
lstoakes@gmail.com, geliangtang@163.com, viro@zeniv.linux.org.uk,
hughd@google.com, riel@redhat.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, teawater@gmail.com
Subject: Re: [RFC 0/2] Add interface let ZRAM close swap cache
Date: Mon, 28 Nov 2016 15:49:17 +0100 [thread overview]
Message-ID: <20161128144917.GQ14788@dhcp22.suse.cz> (raw)
In-Reply-To: <1480062313-7361-1-git-send-email-zhuhui@xiaomi.com>
On Fri 25-11-16 16:25:11, Hui Zhu wrote:
> SWAP will keep before swap cache before swap space get full. It will
> make swap space cannot be freed. It is harmful to the system that use
> ZRAM because its space use memory too.
I have hard time to follow what you are trying to say here. Could you be
more specific about what is the actual problem?
> This two patches will add a sysfs switch to ZRAM that open or close swap
> cache without check the swap space.
I find this a crude hack to be honest. Please make sure to describe why
the swap cache stays in the way and why this is not problem in other
setups.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-11-28 14:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 8:25 Hui Zhu
2016-11-25 8:25 ` [RFC 1/2] SWAP: add interface to let disk " Hui Zhu
2016-11-25 8:25 ` [RFC 2/2] ZRAM: add sysfs switch swap_cache_not_keep Hui Zhu
2016-11-28 14:49 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128144917.GQ14788@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=geliangtang@163.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jmarchan@redhat.com \
--cc=jthumshirn@suse.de \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=mgorman@techsingularity.net \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=re.emese@gmail.com \
--cc=riel@redhat.com \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=teawater@gmail.com \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vishal.l.verma@intel.com \
--cc=vitalywool@gmail.com \
--cc=vkuznets@redhat.com \
--cc=willy@linux.intel.com \
--cc=yang.shi@linaro.org \
--cc=ying.huang@intel.com \
--cc=zhuhui@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox