From: Michal Hocko <mhocko@kernel.org>
To: Balbir Singh <bsingharora@gmail.com>
Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [mm v2 0/3] Support memory cgroup hotplug
Date: Wed, 23 Nov 2016 14:22:27 +0100 [thread overview]
Message-ID: <20161123132226.GL2864@dhcp22.suse.cz> (raw)
In-Reply-To: <962ac541-55c4-de09-59a3-4947c394eee6@gmail.com>
On Thu 24-11-16 00:05:12, Balbir Singh wrote:
>
>
> On 23/11/16 20:28, Michal Hocko wrote:
[...]
> > I am more worried about synchronization with the hotplug which tends to
> > be a PITA in places were we were simply safe by definition until now. We
> > do not have all that many users of memcg->nodeinfo[nid] from what I can see
> > but are all of them safe to never race with the hotplug. A lack of
> > highlevel design description is less than encouraging.
>
> As in explanation? The design is dictated by the notifier and the actions
> to take when the node comes online/offline.
Sure but how all the users of lruvec (for example) which is stored in
the nodeinfo AFAIR, are supposed to synchronize with the notifier.
Really if you are doing something dynamic then the first thing to
explain is the sychronization. There might be really good reasons why we
do not have to care about explicit synchr. for most code paths but my
past experience with many subtle hotplug related bugs just make me a bit
suspicious. So in other words, please make sure to document as much as
possible. This will make the review so much easier.
> So please try to
> > spend some time describing how do we use nodeinfo currently and how is
> > the synchronization with the hotplug supposed to work and what
> > guarantees that no stale nodinfos can be ever used. This is just too
> > easy to get wrong...
> >
>
> OK.. I'll add that in the next cover letter
Thanks!
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-11-23 13:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 4:36 Balbir Singh
2016-11-23 4:36 ` [mm v2 1/3] mm: Add basic infrastructure for memcg hotplug support Balbir Singh
2016-11-23 4:36 ` [mm v2 2/3] mm: Move operations to hotplug callbacks Balbir Singh
2016-11-23 4:36 ` [mm v2 3/3] powerpc/mm: fix node_possible_map limitations Balbir Singh
2016-11-23 7:25 ` [mm v2 0/3] Support memory cgroup hotplug Michal Hocko
2016-11-23 7:50 ` Balbir Singh
2016-11-23 8:07 ` Michal Hocko
2016-11-23 8:37 ` Balbir Singh
2016-11-23 9:28 ` Michal Hocko
2016-11-23 13:05 ` Balbir Singh
2016-11-23 13:22 ` Michal Hocko [this message]
2016-11-28 21:10 ` Tejun Heo
2016-11-29 0:09 ` Balbir Singh
2016-11-29 0:42 ` Tejun Heo
2016-11-29 4:57 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123132226.GL2864@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox