Re: [PATCH] filemap: add comment for confusing logic in page_cache_tree_insert()

[Jan Kara <jack@suse.cz>]

On Thu 10-11-16 19:36:40, Kirill A. Shutemov wrote:
> Unlike THP, hugetlb pages represented by one entry on radix-tree.
> 
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Jan Kara <jack@suse.cz>

Thanks!

								Honza
> ---
>  mm/filemap.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 849f459ad078..7602e8fabf5e 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -169,7 +169,10 @@ static int page_cache_tree_insert(struct address_space *mapping,
>  static void page_cache_tree_delete(struct address_space *mapping,
>  				   struct page *page, void *shadow)
>  {
> -	int i, nr = PageHuge(page) ? 1 : hpage_nr_pages(page);
> +	int i, nr;
> +
> +	/* hugetlb pages represented by one entry on radix-tree */
> +	nr = PageHuge(page) ? 1 : hpage_nr_pages(page);
>  
>  	VM_BUG_ON_PAGE(!PageLocked(page), page);
>  	VM_BUG_ON_PAGE(PageTail(page), page);
> -- 
> 2.9.3
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>