From: Alexander Duyck <alexander.h.duyck@intel.com>
To: linux-mm@kvack.org, akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, Helge Deller <deller@gmx.de>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [mm PATCH v3 14/23] arch/parisc: Add option to skip DMA sync as a part of map and unmap
Date: Thu, 10 Nov 2016 06:35:29 -0500 [thread overview]
Message-ID: <20161110113529.76501.44762.stgit@ahduyck-blue-test.jf.intel.com> (raw)
In-Reply-To: <20161110113027.76501.63030.stgit@ahduyck-blue-test.jf.intel.com>
This change allows us to pass DMA_ATTR_SKIP_CPU_SYNC which allows us to
avoid invoking cache line invalidation if the driver will just handle it
via a sync_for_cpu or sync_for_device call.
Cc: "James E.J. Bottomley" <jejb@parisc-linux.org>
Cc: Helge Deller <deller@gmx.de>
Cc: linux-parisc@vger.kernel.org
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
arch/parisc/kernel/pci-dma.c | 20 +++++++++++++++-----
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci-dma.c
index 02d9ed0..be55ede 100644
--- a/arch/parisc/kernel/pci-dma.c
+++ b/arch/parisc/kernel/pci-dma.c
@@ -459,7 +459,9 @@ static dma_addr_t pa11_dma_map_page(struct device *dev, struct page *page,
void *addr = page_address(page) + offset;
BUG_ON(direction == DMA_NONE);
- flush_kernel_dcache_range((unsigned long) addr, size);
+ if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC))
+ flush_kernel_dcache_range((unsigned long) addr, size);
+
return virt_to_phys(addr);
}
@@ -469,8 +471,11 @@ static void pa11_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
{
BUG_ON(direction == DMA_NONE);
+ if (attrs & DMA_ATTR_SKIP_CPU_SYNC)
+ return;
+
if (direction == DMA_TO_DEVICE)
- return;
+ return;
/*
* For PCI_DMA_FROMDEVICE this flush is not necessary for the
@@ -479,7 +484,6 @@ static void pa11_dma_unmap_page(struct device *dev, dma_addr_t dma_handle,
*/
flush_kernel_dcache_range((unsigned long) phys_to_virt(dma_handle), size);
- return;
}
static int pa11_dma_map_sg(struct device *dev, struct scatterlist *sglist,
@@ -496,6 +500,10 @@ static int pa11_dma_map_sg(struct device *dev, struct scatterlist *sglist,
sg_dma_address(sg) = (dma_addr_t) virt_to_phys(vaddr);
sg_dma_len(sg) = sg->length;
+
+ if (attrs & DMA_ATTR_SKIP_CPU_SYNC)
+ continue;
+
flush_kernel_dcache_range(vaddr, sg->length);
}
return nents;
@@ -510,14 +518,16 @@ static void pa11_dma_unmap_sg(struct device *dev, struct scatterlist *sglist,
BUG_ON(direction == DMA_NONE);
+ if (attrs & DMA_ATTR_SKIP_CPU_SYNC)
+ return;
+
if (direction == DMA_TO_DEVICE)
- return;
+ return;
/* once we do combining we'll need to use phys_to_virt(sg_dma_address(sglist)) */
for_each_sg(sglist, sg, nents, i)
flush_kernel_vmap_range(sg_virt(sg), sg->length);
- return;
}
static void pa11_dma_sync_single_for_cpu(struct device *dev,
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-11-10 17:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 11:34 [mm PATCH v3 00/23] Add support for DMA writable pages being writable by the network stack Alexander Duyck
2016-11-10 11:34 ` [mm PATCH v3 01/23] arch/arc: Add option to skip sync on DMA mapping Alexander Duyck
2016-11-10 11:34 ` [mm PATCH v3 02/23] arch/arm: Add option to skip sync on DMA map and unmap Alexander Duyck
2016-11-10 11:34 ` [mm PATCH v3 03/23] arch/avr32: Add option to skip sync on DMA map Alexander Duyck
2016-11-10 11:34 ` [mm PATCH v3 04/23] arch/blackfin: " Alexander Duyck
2016-11-10 11:34 ` [mm PATCH v3 05/23] arch/c6x: Add option to skip sync on DMA map and unmap Alexander Duyck
2016-11-10 11:34 ` [mm PATCH v3 06/23] arch/frv: Add option to skip sync on DMA map Alexander Duyck
2016-11-10 11:34 ` [mm PATCH v3 07/23] arch/hexagon: Add option to skip DMA sync as a part of mapping Alexander Duyck
2016-11-10 18:40 ` Richard Kuo
2016-11-10 11:34 ` [mm PATCH v3 08/23] arch/m68k: " Alexander Duyck
2016-11-10 11:35 ` [mm PATCH v3 09/23] arch/metag: Add option to skip DMA sync as a part of map and unmap Alexander Duyck
2016-11-10 11:35 ` [mm PATCH v3 10/23] arch/microblaze: " Alexander Duyck
2016-11-10 11:35 ` [mm PATCH v3 11/23] arch/mips: " Alexander Duyck
2016-11-10 11:35 ` [mm PATCH v3 12/23] arch/nios2: " Alexander Duyck
2016-11-11 10:58 ` Tobias Klauser
2016-11-10 11:35 ` [mm PATCH v3 13/23] arch/openrisc: Add option to skip DMA sync as a part of mapping Alexander Duyck
2016-11-10 11:35 ` Alexander Duyck [this message]
2016-11-10 11:35 ` [mm PATCH v3 15/23] arch/powerpc: " Alexander Duyck
2016-11-10 11:35 ` [mm PATCH v3 16/23] arch/sh: " Alexander Duyck
2016-11-10 11:35 ` [mm PATCH v3 17/23] arch/sparc: Add option to skip DMA sync as a part of map and unmap Alexander Duyck
2016-11-13 17:27 ` David Miller
2016-11-10 11:35 ` [mm PATCH v3 18/23] arch/tile: " Alexander Duyck
2016-11-10 11:35 ` [mm PATCH v3 19/23] arch/xtensa: Add option to skip DMA sync as a part of mapping Alexander Duyck
2016-11-10 11:36 ` [mm PATCH v3 20/23] dma: Add calls for dma_map_page_attrs and dma_unmap_page_attrs Alexander Duyck
2016-11-10 11:36 ` [mm PATCH v3 21/23] mm: Add support for releasing multiple instances of a page Alexander Duyck
2016-11-18 23:27 ` Andrew Morton
2016-11-21 16:21 ` Alexander Duyck
2016-11-22 6:28 ` Andrew Morton
2016-11-10 11:36 ` [mm PATCH v3 22/23] igb: Update driver to make use of DMA_ATTR_SKIP_CPU_SYNC Alexander Duyck
2016-11-10 11:36 ` [mm PATCH v3 23/23] igb: Update code to better handle incrementing page count Alexander Duyck
2016-11-18 16:10 ` [mm PATCH v3 00/23] Add support for DMA writable pages being writable by the network stack Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110113529.76501.44762.stgit@ahduyck-blue-test.jf.intel.com \
--to=alexander.h.duyck@intel.com \
--cc=akpm@linux-foundation.org \
--cc=deller@gmx.de \
--cc=jejb@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox