From: Alexander Duyck <alexander.h.duyck@intel.com>
To: linux-mm@kvack.org, akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org
Subject: [mm PATCH v3 02/23] arch/arm: Add option to skip sync on DMA map and unmap
Date: Thu, 10 Nov 2016 06:34:25 -0500 [thread overview]
Message-ID: <20161110113424.76501.2715.stgit@ahduyck-blue-test.jf.intel.com> (raw)
In-Reply-To: <20161110113027.76501.63030.stgit@ahduyck-blue-test.jf.intel.com>
The use of DMA_ATTR_SKIP_CPU_SYNC was not consistent across all of the DMA
APIs in the arch/arm folder. This change is meant to correct that so that
we get consistent behavior.
Cc: Russell King <linux@armlinux.org.uk>
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
arch/arm/common/dmabounce.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
index 3012816..75055df 100644
--- a/arch/arm/common/dmabounce.c
+++ b/arch/arm/common/dmabounce.c
@@ -243,7 +243,8 @@ static int needs_bounce(struct device *dev, dma_addr_t dma_addr, size_t size)
}
static inline dma_addr_t map_single(struct device *dev, void *ptr, size_t size,
- enum dma_data_direction dir)
+ enum dma_data_direction dir,
+ unsigned long attrs)
{
struct dmabounce_device_info *device_info = dev->archdata.dmabounce;
struct safe_buffer *buf;
@@ -262,7 +263,8 @@ static inline dma_addr_t map_single(struct device *dev, void *ptr, size_t size,
__func__, buf->ptr, virt_to_dma(dev, buf->ptr),
buf->safe, buf->safe_dma_addr);
- if (dir == DMA_TO_DEVICE || dir == DMA_BIDIRECTIONAL) {
+ if ((dir == DMA_TO_DEVICE || dir == DMA_BIDIRECTIONAL) &&
+ !(attrs & DMA_ATTR_SKIP_CPU_SYNC)) {
dev_dbg(dev, "%s: copy unsafe %p to safe %p, size %d\n",
__func__, ptr, buf->safe, size);
memcpy(buf->safe, ptr, size);
@@ -272,7 +274,8 @@ static inline dma_addr_t map_single(struct device *dev, void *ptr, size_t size,
}
static inline void unmap_single(struct device *dev, struct safe_buffer *buf,
- size_t size, enum dma_data_direction dir)
+ size_t size, enum dma_data_direction dir,
+ unsigned long attrs)
{
BUG_ON(buf->size != size);
BUG_ON(buf->direction != dir);
@@ -283,7 +286,8 @@ static inline void unmap_single(struct device *dev, struct safe_buffer *buf,
DO_STATS(dev->archdata.dmabounce->bounce_count++);
- if (dir == DMA_FROM_DEVICE || dir == DMA_BIDIRECTIONAL) {
+ if ((dir == DMA_FROM_DEVICE || dir == DMA_BIDIRECTIONAL) &&
+ !(attrs & DMA_ATTR_SKIP_CPU_SYNC)) {
void *ptr = buf->ptr;
dev_dbg(dev, "%s: copy back safe %p to unsafe %p size %d\n",
@@ -334,7 +338,7 @@ static dma_addr_t dmabounce_map_page(struct device *dev, struct page *page,
return DMA_ERROR_CODE;
}
- return map_single(dev, page_address(page) + offset, size, dir);
+ return map_single(dev, page_address(page) + offset, size, dir, attrs);
}
/*
@@ -357,7 +361,7 @@ static void dmabounce_unmap_page(struct device *dev, dma_addr_t dma_addr, size_t
return;
}
- unmap_single(dev, buf, size, dir);
+ unmap_single(dev, buf, size, dir, attrs);
}
static int __dmabounce_sync_for_cpu(struct device *dev, dma_addr_t addr,
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-11-10 17:35 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 11:34 [mm PATCH v3 00/23] Add support for DMA writable pages being writable by the network stack Alexander Duyck
2016-11-10 11:34 ` [mm PATCH v3 01/23] arch/arc: Add option to skip sync on DMA mapping Alexander Duyck
2016-11-10 11:34 ` Alexander Duyck [this message]
2016-11-10 11:34 ` [mm PATCH v3 03/23] arch/avr32: Add option to skip sync on DMA map Alexander Duyck
2016-11-10 11:34 ` [mm PATCH v3 04/23] arch/blackfin: " Alexander Duyck
2016-11-10 11:34 ` [mm PATCH v3 05/23] arch/c6x: Add option to skip sync on DMA map and unmap Alexander Duyck
2016-11-10 11:34 ` [mm PATCH v3 06/23] arch/frv: Add option to skip sync on DMA map Alexander Duyck
2016-11-10 11:34 ` [mm PATCH v3 07/23] arch/hexagon: Add option to skip DMA sync as a part of mapping Alexander Duyck
2016-11-10 18:40 ` Richard Kuo
2016-11-10 11:34 ` [mm PATCH v3 08/23] arch/m68k: " Alexander Duyck
2016-11-10 11:35 ` [mm PATCH v3 09/23] arch/metag: Add option to skip DMA sync as a part of map and unmap Alexander Duyck
2016-11-10 11:35 ` [mm PATCH v3 10/23] arch/microblaze: " Alexander Duyck
2016-11-10 11:35 ` [mm PATCH v3 11/23] arch/mips: " Alexander Duyck
2016-11-10 11:35 ` [mm PATCH v3 12/23] arch/nios2: " Alexander Duyck
2016-11-11 10:58 ` Tobias Klauser
2016-11-10 11:35 ` [mm PATCH v3 13/23] arch/openrisc: Add option to skip DMA sync as a part of mapping Alexander Duyck
2016-11-10 11:35 ` [mm PATCH v3 14/23] arch/parisc: Add option to skip DMA sync as a part of map and unmap Alexander Duyck
2016-11-10 11:35 ` [mm PATCH v3 15/23] arch/powerpc: Add option to skip DMA sync as a part of mapping Alexander Duyck
2016-11-10 11:35 ` [mm PATCH v3 16/23] arch/sh: " Alexander Duyck
2016-11-10 11:35 ` [mm PATCH v3 17/23] arch/sparc: Add option to skip DMA sync as a part of map and unmap Alexander Duyck
2016-11-13 17:27 ` David Miller
2016-11-10 11:35 ` [mm PATCH v3 18/23] arch/tile: " Alexander Duyck
2016-11-10 11:35 ` [mm PATCH v3 19/23] arch/xtensa: Add option to skip DMA sync as a part of mapping Alexander Duyck
2016-11-10 11:36 ` [mm PATCH v3 20/23] dma: Add calls for dma_map_page_attrs and dma_unmap_page_attrs Alexander Duyck
2016-11-10 11:36 ` [mm PATCH v3 21/23] mm: Add support for releasing multiple instances of a page Alexander Duyck
2016-11-18 23:27 ` Andrew Morton
2016-11-21 16:21 ` Alexander Duyck
2016-11-22 6:28 ` Andrew Morton
2016-11-10 11:36 ` [mm PATCH v3 22/23] igb: Update driver to make use of DMA_ATTR_SKIP_CPU_SYNC Alexander Duyck
2016-11-10 11:36 ` [mm PATCH v3 23/23] igb: Update code to better handle incrementing page count Alexander Duyck
2016-11-18 16:10 ` [mm PATCH v3 00/23] Add support for DMA writable pages being writable by the network stack Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110113424.76501.2715.stgit@ahduyck-blue-test.jf.intel.com \
--to=alexander.h.duyck@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox