From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f69.google.com (mail-pa0-f69.google.com [209.85.220.69]) by kanga.kvack.org (Postfix) with ESMTP id 1FE72280258 for ; Thu, 3 Nov 2016 15:17:23 -0400 (EDT) Received: by mail-pa0-f69.google.com with SMTP id ro13so26738296pac.7 for ; Thu, 03 Nov 2016 12:17:23 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id ft11si5703660pac.111.2016.11.03.12.17.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Nov 2016 12:17:22 -0700 (PDT) Date: Thu, 3 Nov 2016 12:17:21 -0700 From: Andrew Morton Subject: Re: [RFC PATCH] hugetlbfs: fix the hugetlbfs can not be mounted Message-Id: <20161103121721.50040185d201e3aac27fd366@linux-foundation.org> In-Reply-To: <1477721311-54522-1-git-send-email-zhongjiang@huawei.com> References: <1477721311-54522-1-git-send-email-zhongjiang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: zhongjiang Cc: nyc@holomorphy.com, n-horiguchi@ah.jp.nec.com, mike.kravetz@oracle.com, rientjes@google.com, hillf.zj@alibaba-inc.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Paul Gortmaker On Sat, 29 Oct 2016 14:08:31 +0800 zhongjiang wrote: > From: zhong jiang > > Since 'commit 3e89e1c5ea84 ("hugetlb: make mm and fs code explicitly non-modular")' > bring in the mainline. mount hugetlbfs will result in the following issue. > > mount: unknown filesystme type 'hugetlbfs' > > because previous patch remove the module_alias_fs, when we mount the fs type, > the caller get_fs_type can not find the filesystem. > > The patch just recover the module_alias_fs to identify the hugetlbfs. hm, 3e89e1c5ea84 ("hugetlb: make mm and fs code explicitly non-modular") was merged almost a year ago. And you are apparently the first person to discover this regression. Can you think why that is? > index 4fb7b10..b63e7de 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -35,6 +35,7 @@ > #include > #include > #include > +#include > #include > > #include > @@ -1209,6 +1210,7 @@ static struct dentry *hugetlbfs_mount(struct file_system_type *fs_type, > .mount = hugetlbfs_mount, > .kill_sb = kill_litter_super, > }; > +MODULE_ALIAS_FS("hugetlbfs"); > > static struct vfsmount *hugetlbfs_vfsmount[HUGE_MAX_HSTATE]; > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org