From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f70.google.com (mail-pa0-f70.google.com [209.85.220.70]) by kanga.kvack.org (Postfix) with ESMTP id 487FC6B0253 for ; Wed, 2 Nov 2016 18:52:48 -0400 (EDT) Received: by mail-pa0-f70.google.com with SMTP id gg9so13907352pac.6 for ; Wed, 02 Nov 2016 15:52:48 -0700 (PDT) Received: from foss.arm.com (foss.arm.com. [217.140.101.70]) by mx.google.com with ESMTP id g16si5542702pfj.150.2016.11.02.15.52.47 for ; Wed, 02 Nov 2016 15:52:47 -0700 (PDT) Date: Wed, 2 Nov 2016 22:52:42 +0000 From: Mark Rutland Subject: Re: [PATCHv2 5/6] arm64: Use __pa_symbol for _end Message-ID: <20161102225241.GA19591@remoulade> References: <20161102210054.16621-1-labbott@redhat.com> <20161102210054.16621-6-labbott@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161102210054.16621-6-labbott@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Laura Abbott Cc: Ard Biesheuvel , Will Deacon , Catalin Marinas , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Marek Szyprowski , Joonsoo Kim , linux-arm-kernel@lists.infradead.org On Wed, Nov 02, 2016 at 03:00:53PM -0600, Laura Abbott wrote: > > __pa_symbol is technically the marco that should be used for kernel > symbols. Switch to this as a pre-requisite for DEBUG_VIRTUAL. Nit: s/marco/macro/ I see there are some other uses of __pa() that look like they could/should be __pa_symbol(), e.g. in mark_rodata_ro(). I guess strictly speaking those need to be updated to? Or is there a reason that we should not? Thanks, Mark. > Signed-off-by: Laura Abbott > --- > arch/arm64/mm/init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c > index 212c4d1..3236eb0 100644 > --- a/arch/arm64/mm/init.c > +++ b/arch/arm64/mm/init.c > @@ -209,8 +209,8 @@ void __init arm64_memblock_init(void) > * linear mapping. Take care not to clip the kernel which may be > * high in memory. > */ > - memblock_remove(max_t(u64, memstart_addr + linear_region_size, __pa(_end)), > - ULLONG_MAX); > + memblock_remove(max_t(u64, memstart_addr + linear_region_size, > + __pa_symbol(_end)), ULLONG_MAX); > if (memstart_addr + linear_region_size < memblock_end_of_DRAM()) { > /* ensure that memstart_addr remains sufficiently aligned */ > memstart_addr = round_up(memblock_end_of_DRAM() - linear_region_size, > -- > 2.10.1 > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org