From: Mel Gorman <mgorman@techsingularity.net>
To: zhouxianrong@huawei.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
mingo@redhat.com, peterz@infradead.org, hannes@cmpxchg.org,
vbabka@suse.cz, mhocko@suse.com, vdavydov.dev@gmail.com,
minchan@kernel.org, riel@redhat.com, zhouxiyu@huawei.com,
zhangshiming5@huawei.com, won.ho.park@huawei.com,
tuxiaobing@huawei.com
Subject: Re: [PATCH] bdi flusher should not be throttled here when it fall into buddy slow path
Date: Tue, 18 Oct 2016 10:59:12 +0100 [thread overview]
Message-ID: <20161018095912.GD22174@techsingularity.net> (raw)
In-Reply-To: <1476774765-21130-1-git-send-email-zhouxianrong@huawei.com>
On Tue, Oct 18, 2016 at 03:12:45PM +0800, zhouxianrong@huawei.com wrote:
> From: z00281421 <z00281421@notesmail.huawei.com>
>
> bdi flusher may enter page alloc slow path due to writepage and kmalloc.
> in that case the flusher as a direct reclaimer should not be throttled here
> because it can not to reclaim clean file pages or anaonymous pages
> for next moment; furthermore writeback rate of dirty pages would be
> slow down and other direct reclaimers and kswapd would be affected.
> bdi flusher should be iosceduled by get_request rather than here.
>
> Signed-off-by: z00281421 <z00281421@notesmail.huawei.com>
What does this patch do that PF_LESS_THROTTLE is not doing already if
there is an underlying BDI?
There have been a few patches like this recently that look like they might
do something useful but are subtle. They really should be accompanied by
a test case and data showing they either fix a functional issue (machine
livelocking due to writeback not making progress) or a performance issue.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-10-18 9:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 7:12 zhouxianrong
2016-10-18 9:34 ` Hillf Danton
2016-10-18 9:59 ` Mel Gorman [this message]
2016-10-18 11:08 ` zhouxianrong
2016-10-18 11:42 ` Michal Hocko
2016-10-20 12:38 ` zhouxianrong
2016-10-20 13:05 ` Mika Penttilä
2016-10-20 13:28 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018095912.GD22174@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=tuxiaobing@huawei.com \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=won.ho.park@huawei.com \
--cc=zhangshiming5@huawei.com \
--cc=zhouxianrong@huawei.com \
--cc=zhouxiyu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox