From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Hugh Dickins <hughd@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Andi Kleen <ak@linux.intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] shmem: avoid huge pages for small files
Date: Mon, 17 Oct 2016 15:30:21 +0300 [thread overview]
Message-ID: <20161017123021.rlyz44dsf4l4xnve@black.fi.intel.com> (raw)
In-Reply-To: <20161017121809.189039-1-kirill.shutemov@linux.intel.com>
On Mon, Oct 17, 2016 at 03:18:09PM +0300, Kirill A. Shutemov wrote:
> diff --git a/mm/shmem.c b/mm/shmem.c
> index ad7813d73ea7..c69047386e2f 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -369,6 +369,7 @@ static bool shmem_confirm_swap(struct address_space *mapping,
> /* ifdef here to avoid bloating shmem.o when not necessary */
>
> int shmem_huge __read_mostly;
> +unsigned long long shmem_huge_min_size = HPAGE_PMD_SIZE __read_mostly;
Arghh.. Last second changes...
This should be
unsigned long long shmem_huge_min_size __read_mostly = HPAGE_PMD_SIZE;
next prev parent reply other threads:[~2016-10-17 12:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 12:18 Kirill A. Shutemov
2016-10-17 12:30 ` Kirill A. Shutemov [this message]
2016-10-17 14:12 ` Michal Hocko
2016-10-17 14:55 ` Kirill A. Shutemov
2016-10-18 14:20 ` Michal Hocko
2016-10-18 14:32 ` Kirill A. Shutemov
2016-10-18 18:30 ` Michal Hocko
2016-10-19 18:13 ` Hugh Dickins
2016-10-20 10:39 ` Kirill A. Shutemov
2016-10-20 22:46 ` Dave Chinner
2016-10-21 2:01 ` Andi Kleen
2016-10-21 5:01 ` Dave Chinner
2016-10-21 15:00 ` Kirill A. Shutemov
2016-10-21 15:12 ` Michal Hocko
2016-10-21 22:50 ` Dave Chinner
2016-10-21 23:32 ` Kirill A. Shutemov
2016-10-24 20:34 ` Dave Hansen
2016-10-25 5:28 ` Dave Chinner
2016-11-10 16:25 [PATCHv4] " Kirill A. Shutemov
2016-11-10 17:42 ` [PATCH] " kbuild test robot
2016-11-10 17:51 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017123021.rlyz44dsf4l4xnve@black.fi.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox