From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
Theodore Ts'o <tytso@mit.edu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <david@fromorbit.com>, Jan Kara <jack@suse.cz>,
Matthew Wilcox <mawilcox@microsoft.com>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-nvdimm@lists.01.org,
linux-xfs@vger.kernel.org
Subject: [PATCH v6 05/17] dax: make 'wait_table' global variable static
Date: Wed, 12 Oct 2016 16:50:10 -0600 [thread overview]
Message-ID: <20161012225022.15507-6-ross.zwisler@linux.intel.com> (raw)
In-Reply-To: <20161012225022.15507-1-ross.zwisler@linux.intel.com>
The global 'wait_table' variable is only used within fs/dax.c, and
generates the following sparse warning:
fs/dax.c:39:19: warning: symbol 'wait_table' was not declared. Should it be static?
Make it static so it has scope local to fs/dax.c, and to make sparse happy.
Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
---
fs/dax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/dax.c b/fs/dax.c
index 9b9be8a..ac28cdf 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -52,7 +52,7 @@
#define DAX_WAIT_TABLE_BITS 12
#define DAX_WAIT_TABLE_ENTRIES (1 << DAX_WAIT_TABLE_BITS)
-wait_queue_head_t wait_table[DAX_WAIT_TABLE_ENTRIES];
+static wait_queue_head_t wait_table[DAX_WAIT_TABLE_ENTRIES];
static int __init init_dax_wait_table(void)
{
--
2.9.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-10-12 22:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 22:50 [PATCH v6 00/17] re-enable DAX PMD support Ross Zwisler
2016-10-12 22:50 ` [PATCH v6 01/17] ext4: allow DAX writeback for hole punch Ross Zwisler
2016-10-12 22:50 ` [PATCH v6 02/17] ext4: tell DAX the size of allocation holes Ross Zwisler
2016-10-12 22:50 ` [PATCH v6 03/17] dax: remove buffer_size_valid() Ross Zwisler
2016-10-12 22:50 ` [PATCH v6 04/17] ext2: remove support for DAX PMD faults Ross Zwisler
2016-10-12 22:50 ` Ross Zwisler [this message]
2016-10-12 22:50 ` [PATCH v6 06/17] dax: remove the last BUG_ON() from fs/dax.c Ross Zwisler
2016-10-12 22:50 ` [PATCH v6 07/17] dax: consistent variable naming for DAX entries Ross Zwisler
2016-10-12 22:50 ` [PATCH v6 08/17] dax: coordinate locking for offsets in PMD range Ross Zwisler
2016-10-12 22:50 ` [PATCH v6 09/17] dax: remove dax_pmd_fault() Ross Zwisler
2016-10-12 22:50 ` [PATCH v6 10/17] dax: correct dax iomap code namespace Ross Zwisler
2016-10-12 22:50 ` [PATCH v6 11/17] dax: add dax_iomap_sector() helper function Ross Zwisler
2016-10-12 22:50 ` [PATCH v6 12/17] dax: dax_iomap_fault() needs to call iomap_end() Ross Zwisler
2016-10-12 22:50 ` [PATCH v6 13/17] dax: move RADIX_DAX_* defines to dax.h Ross Zwisler
2016-10-12 22:50 ` [PATCH v6 14/17] dax: move put_(un)locked_mapping_entry() in dax.c Ross Zwisler
2016-10-13 15:11 ` Jan Kara
2016-10-12 22:50 ` [PATCH v6 15/17] dax: add struct iomap based DAX PMD support Ross Zwisler
2016-10-13 15:42 ` Jan Kara
2016-10-13 19:23 ` [PATCH v7 " Ross Zwisler
2016-10-17 6:06 ` Aneesh Kumar K.V
2016-10-17 14:55 ` Ross Zwisler
2016-10-13 19:25 ` [PATCH v6 " Ross Zwisler
2016-10-12 22:50 ` [PATCH v6 16/17] xfs: use struct iomap based DAX PMD fault path Ross Zwisler
2016-10-12 22:50 ` [PATCH v6 17/17] dax: remove "depends on BROKEN" from FS_DAX_PMD Ross Zwisler
2016-10-13 15:42 ` Jan Kara
2016-10-17 5:57 ` Aneesh Kumar K.V
2016-10-17 9:09 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012225022.15507-6-ross.zwisler@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox