From: Michal Hocko <mhocko@kernel.org>
To: zijun_hu <zijun_hu@zoho.com>
Cc: tj@kernel.org, akpm@linux-foundation.org, zijun_hu@htc.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org, cl@linux.com
Subject: Re: [RFC PATCH 1/1] mm/percpu.c: fix memory leakage issue when allocate a odd alignment area
Date: Tue, 11 Oct 2016 19:22:29 +0200 [thread overview]
Message-ID: <20161011172228.GA30403@dhcp22.suse.cz> (raw)
In-Reply-To: <bc3126cd-226d-91c7-d323-48881095accf@zoho.com>
On Tue 11-10-16 21:24:50, zijun_hu wrote:
> From: zijun_hu <zijun_hu@htc.com>
>
> the LSB of a chunk->map element is used for free/in-use flag of a area
> and the other bits for offset, the sufficient and necessary condition of
> this usage is that both size and alignment of a area must be even numbers
> however, pcpu_alloc() doesn't force its @align parameter a even number
> explicitly, so a odd @align maybe causes a series of errors, see below
> example for concrete descriptions.
Is or was there any user who would use a different than even (or power of 2)
alighment? If not is this really worth handling?
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-10-11 17:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 13:24 zijun_hu
2016-10-11 17:22 ` Michal Hocko [this message]
2016-10-12 0:28 ` zijun_hu
2016-10-12 6:53 ` Michal Hocko
2016-10-12 7:20 ` zijun_hu
2016-10-12 7:24 ` zijun_hu
2016-10-12 8:25 ` Michal Hocko
2016-10-12 8:44 ` zijun_hu
2016-10-12 9:54 ` Michal Hocko
2016-10-12 9:59 ` zijun_hu
2016-10-13 23:31 ` Tejun Heo
2016-10-14 0:23 ` zijun_hu
2016-10-14 0:28 ` Tejun Heo
2016-10-14 0:58 ` zijun_hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161011172228.GA30403@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
--cc=zijun_hu@htc.com \
--cc=zijun_hu@zoho.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox