From: Chris Wilson <chris@chris-wilson.co.uk>
To: Joel Fernandes <joel.opensrc@gmail.com>
Cc: Joel Fernandes <agnel.joel@gmail.com>,
Jisheng Zhang <jszhang@marvell.com>,
npiggin@kernel.dk,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, rientjes@google.com,
Andrew Morton <akpm@linux-foundation.org>,
mgorman@techsingularity.net, iamjoonsoo.kim@lge.com,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] mm/vmalloc: reduce the number of lazy_max_pages to reduce latency
Date: Sun, 9 Oct 2016 20:26:11 +0100 [thread overview]
Message-ID: <20161009192610.GB2718@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <CAEi0qNnozbib-92NwWpUV=_YiiUHYGzzBuuY8kDZY9gaZm-W7Q@mail.gmail.com>
On Sun, Oct 09, 2016 at 12:00:31PM -0700, Joel Fernandes wrote:
> Ok. So I'll submit a patch with mutex for purge_lock and use
> cond_resched_lock for the vmap_area_lock as you suggested. I'll also
> drop the lazy_max_pages to 8MB as Andi suggested to reduce the lock
> hold time. Let me know if you have any objections.
The downside of using a mutex here though, is that we may be called
from contexts that cannot sleep (alloc_vmap_area), or reschedule for
that matter! If we change the notion of purged, we can forgo the mutex
in favour of spinning on the direct reclaim path. That just leaves the
complication of whether to use cond_resched_lock() or a lock around
the individual __free_vmap_area().
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-10-09 19:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 7:34 Jisheng Zhang
2016-09-29 8:18 ` Chris Wilson
2016-09-29 8:28 ` Jisheng Zhang
2016-09-29 11:07 ` Chris Wilson
2016-09-29 11:18 ` Jisheng Zhang
2016-10-09 3:43 ` Joel Fernandes
2016-10-09 12:42 ` Chris Wilson
2016-10-09 19:00 ` Joel Fernandes
2016-10-09 19:26 ` Chris Wilson [this message]
2016-10-11 5:06 ` Joel Fernandes
2016-10-11 5:34 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161009192610.GB2718@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=agnel.joel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=joel.opensrc@gmail.com \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=npiggin@kernel.dk \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox