From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f71.google.com (mail-wm0-f71.google.com [74.125.82.71]) by kanga.kvack.org (Postfix) with ESMTP id DBE516B0261 for ; Mon, 3 Oct 2016 05:36:04 -0400 (EDT) Received: by mail-wm0-f71.google.com with SMTP id b201so36185139wmb.2 for ; Mon, 03 Oct 2016 02:36:04 -0700 (PDT) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id go11si33848766wjd.31.2016.10.03.02.36.03 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 03 Oct 2016 02:36:03 -0700 (PDT) Date: Mon, 3 Oct 2016 11:36:03 +0200 From: Jan Kara Subject: Re: [PATCH v4 05/12] dax: make 'wait_table' global variable static Message-ID: <20161003093603.GK6457@quack2.suse.cz> References: <1475189370-31634-1-git-send-email-ross.zwisler@linux.intel.com> <1475189370-31634-6-git-send-email-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475189370-31634-6-git-send-email-ross.zwisler@linux.intel.com> Sender: owner-linux-mm@kvack.org List-ID: To: Ross Zwisler Cc: linux-kernel@vger.kernel.org, Theodore Ts'o , Alexander Viro , Andreas Dilger , Andrew Morton , Christoph Hellwig , Dan Williams , Dave Chinner , Jan Kara , Matthew Wilcox , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org On Thu 29-09-16 16:49:23, Ross Zwisler wrote: > The global 'wait_table' variable is only used within fs/dax.c, and > generates the following sparse warning: > > fs/dax.c:39:19: warning: symbol 'wait_table' was not declared. Should it be static? > > Make it static so it has scope local to fs/dax.c, and to make sparse happy. > > Signed-off-by: Ross Zwisler Looks fine. You can add: Reviewed-by: Jan Kara Honza > --- > fs/dax.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/dax.c b/fs/dax.c > index 9b9be8a..ac28cdf 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -52,7 +52,7 @@ > #define DAX_WAIT_TABLE_BITS 12 > #define DAX_WAIT_TABLE_ENTRIES (1 << DAX_WAIT_TABLE_BITS) > > -wait_queue_head_t wait_table[DAX_WAIT_TABLE_ENTRIES]; > +static wait_queue_head_t wait_table[DAX_WAIT_TABLE_ENTRIES]; > > static int __init init_dax_wait_table(void) > { > -- > 2.7.4 > > -- Jan Kara SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org