From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: zhongjiang <zhongjiang@huawei.com>
Cc: "mike.kravetz@oracle.com" <mike.kravetz@oracle.com>,
"mhocko@kernel.org" <mhocko@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH v2] mm: remove unnecessary condition in remove_inode_hugepages
Date: Wed, 28 Sep 2016 05:48:28 +0000 [thread overview]
Message-ID: <20160928054827.GA27463@hori1.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <1474985786-5052-1-git-send-email-zhongjiang@huawei.com>
On Tue, Sep 27, 2016 at 10:16:26PM +0800, zhongjiang wrote:
> From: zhong jiang <zhongjiang@huawei.com>
>
> when the huge page is added to the page cahce (huge_add_to_page_cache),
> the page private flag will be cleared. since this code
> (remove_inode_hugepages) will only be called for pages in the
> page cahce, PagePrivate(page) will always be false.
>
> The patch remove the code without any functional change.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Looks good to me.
Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-09-28 23:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 14:16 zhongjiang
2016-09-27 19:23 ` Mike Kravetz
2016-09-28 23:55 ` Mike Kravetz
2016-09-29 1:31 ` zhong jiang
2016-09-28 5:48 ` Naoya Horiguchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928054827.GA27463@hori1.linux.bs1.fc.nec.co.jp \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox