From: Reza Arbab <arbab@linux.vnet.ibm.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Andrew Morton <akpm@linux-foundation.org>,
Bharata B Rao <bharata@linux.vnet.ibm.com>,
Nathan Fontenot <nfont@linux.vnet.ibm.com>,
Stewart Smith <stewart@linux.vnet.ibm.com>,
Alistair Popple <apopple@au1.ibm.com>,
Balbir Singh <bsingharora@gmail.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v3 4/5] powerpc/mm: restore top-down allocation when using movable_node
Date: Mon, 26 Sep 2016 15:48:40 -0500 [thread overview]
Message-ID: <20160926204839.bugxlsyd4p3or5p2@arbab-laptop> (raw)
In-Reply-To: <8760piacio.fsf@linux.vnet.ibm.com>
On Mon, Sep 26, 2016 at 09:17:43PM +0530, Aneesh Kumar K.V wrote:
>> + /* bottom-up allocation may have been set by movable_node */
>> + memblock_set_bottom_up(false);
>> +
>
>By then we have done few memblock allocation right ?
Yes, some allocations do occur while bottom-up is set.
>IMHO, we should do this early enough in prom.c after we do
>parse_early_param, with a comment there explaining that, we don't
>really support hotplug memblock and when we do that, this should be
>moved to a place where we can handle memblock allocation such that we
>avoid spreading memblock allocation to movable node.
Sure, we can do it earlier. The only consideration is that any potential
calls to memblock_mark_hotplug() happen before we reset to top-down.
Since we don't do that at all on power, the call can go anywhere.
--
Reza Arbab
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-09-26 20:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 18:36 [PATCH v3 0/5] powerpc/mm: movable hotplug memory nodes Reza Arbab
2016-09-25 18:36 ` [PATCH v3 1/5] drivers/of: introduce of_fdt_is_available() Reza Arbab
2016-10-03 15:28 ` Rob Herring
2016-09-25 18:36 ` [PATCH v3 2/5] drivers/of: do not add memory for unavailable nodes Reza Arbab
2016-09-25 18:36 ` [PATCH v3 3/5] powerpc/mm: allow memory hotplug into a memoryless node Reza Arbab
2016-09-25 18:36 ` [PATCH v3 4/5] powerpc/mm: restore top-down allocation when using movable_node Reza Arbab
2016-09-26 15:47 ` Aneesh Kumar K.V
2016-09-26 20:48 ` Reza Arbab [this message]
2016-09-26 21:12 ` Benjamin Herrenschmidt
2016-09-27 0:14 ` Reza Arbab
2016-10-04 0:48 ` Balbir Singh
2016-10-04 20:23 ` Reza Arbab
2016-09-25 18:36 ` [PATCH v3 5/5] mm: enable CONFIG_MOVABLE_NODE on powerpc Reza Arbab
2016-09-26 15:48 ` Aneesh Kumar K.V
2016-09-26 21:15 ` Benjamin Herrenschmidt
2016-09-27 0:19 ` Reza Arbab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926204839.bugxlsyd4p3or5p2@arbab-laptop \
--to=arbab@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=apopple@au1.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bharata@linux.vnet.ibm.com \
--cc=bsingharora@gmail.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nfont@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=robh+dt@kernel.org \
--cc=stewart@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox