From: Michal Hocko <mhocko@kernel.org>
To: Robert Ho <robert.hu@intel.com>
Cc: pbonzini@redhat.com, akpm@linux-foundation.org, oleg@redhat.com,
dan.j.williams@intel.com, dave.hansen@intel.com,
guangrong.xiao@linux.intel.com, gleb@kernel.org,
mtosatti@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, stefanha@redhat.com,
yuhuang@redhat.com, linux-mm@kvack.org,
ross.zwisler@linux.intel.com
Subject: Re: [PATCH v3 1/2] mm, proc: Fix region lost in /proc/self/smaps
Date: Fri, 23 Sep 2016 16:39:08 +0200 [thread overview]
Message-ID: <20160923143907.GT4478@dhcp22.suse.cz> (raw)
In-Reply-To: <20160923135051.GQ4478@dhcp22.suse.cz>
On Fri 23-09-16 15:50:51, Michal Hocko wrote:
> On Fri 23-09-16 21:12:33, Robert Ho wrote:
[...]
> > @@ -786,7 +791,7 @@ static int show_smap(struct seq_file *m, void *v, int is_pid)
> > "KernelPageSize: %8lu kB\n"
> > "MMUPageSize: %8lu kB\n"
> > "Locked: %8lu kB\n",
> > - (vma->vm_end - vma->vm_start) >> 10,
> > + (vma->vm_end - max(vma->vm_start, m->version)) >> 10,
> > mss.resident >> 10,
> > (unsigned long)(mss.pss >> (10 + PSS_SHIFT)),
> > mss.shared_clean >> 10,
And forgot to mention that this is not sufficient either. You also need
to restrict the pte walk to get sane numbers...
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-09-23 14:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 13:12 Robert Ho
2016-09-23 13:12 ` [PATCH v3 2/2] Documentation/filesystems/proc.txt: Add more description for maps/smaps Robert Ho
2016-09-23 16:06 ` Dave Hansen
2016-09-28 2:27 ` Robert Hu
2016-09-23 13:50 ` [PATCH v3 1/2] mm, proc: Fix region lost in /proc/self/smaps Michal Hocko
2016-09-23 14:39 ` Michal Hocko [this message]
2016-09-23 13:56 ` Oleg Nesterov
2016-09-23 14:53 ` Michal Hocko
2016-09-23 15:53 ` Oleg Nesterov
2016-09-26 8:46 ` Michal Hocko
2016-09-29 13:14 ` Robert Hu
2016-09-29 13:42 ` Michal Hocko
2016-09-29 13:05 ` Robert Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923143907.GT4478@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=gleb@kernel.org \
--cc=guangrong.xiao@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mtosatti@redhat.com \
--cc=oleg@redhat.com \
--cc=pbonzini@redhat.com \
--cc=robert.hu@intel.com \
--cc=ross.zwisler@linux.intel.com \
--cc=stefanha@redhat.com \
--cc=yuhuang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox