From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f72.google.com (mail-wm0-f72.google.com [74.125.82.72]) by kanga.kvack.org (Postfix) with ESMTP id BD2086B0263 for ; Wed, 21 Sep 2016 04:11:52 -0400 (EDT) Received: by mail-wm0-f72.google.com with SMTP id b130so35288904wmc.2 for ; Wed, 21 Sep 2016 01:11:52 -0700 (PDT) Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com. [74.125.82.52]) by mx.google.com with ESMTPS id zi7si30100248wjb.32.2016.09.21.01.11.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Sep 2016 01:11:51 -0700 (PDT) Received: by mail-wm0-f52.google.com with SMTP id l132so252964294wmf.0 for ; Wed, 21 Sep 2016 01:11:51 -0700 (PDT) Date: Wed, 21 Sep 2016 10:11:50 +0200 From: Michal Hocko Subject: Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy functions Message-ID: <20160921081149.GE10300@dhcp22.suse.cz> References: <1474096836-31045-1-git-send-email-chengang@emindsoft.com.cn> <20160917154659.GA29145@dhcp22.suse.cz> <57E05CD2.5090408@emindsoft.com.cn> <20160920080923.GE5477@dhcp22.suse.cz> <57E1B2F4.5070009@emindsoft.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57E1B2F4.5070009@emindsoft.com.cn> Sender: owner-linux-mm@kvack.org List-ID: To: Chen Gang Cc: akpm@linux-foundation.org, minchan@kernel.org, vbabka@suse.cz, mgorman@techsingularity.net, gi-oh.kim@profitbricks.com, opensource.ganesh@gmail.com, hughd@google.com, kirill.shutemov@linux.intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chen Gang On Wed 21-09-16 06:06:44, Chen Gang wrote: > On 9/20/16 16:09, Michal Hocko wrote: [...] skipping the large part of the email because I do not have a spare time to discuss this. > > So what is the point of this whole exercise? Do not take me wrong, this > > area could see some improvements but I believe that doing int->bool > > change is not just the right thing to do and worth spending both your > > and reviewers time. > > > > I am not quite sure about that. Maybe you should listen to the feedback your are getting. I do not think I am not the first one here. Look, MM surely needs some man power. There are issues to be solved, patches to review. Doing the cleanups is really nice but there are more serious problems to solve first. If you want to help then starting with review would be much much more helpful and hugely appreciated. We are really lacking people there a _lot_. Just generating more work for reviewers with something that doesn't make any real difference in the runtime is far less helpful IMHO. Thanks. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org