From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f72.google.com (mail-vk0-f72.google.com [209.85.213.72]) by kanga.kvack.org (Postfix) with ESMTP id BB5A06B0069 for ; Tue, 13 Sep 2016 10:59:57 -0400 (EDT) Received: by mail-vk0-f72.google.com with SMTP id v189so344110869vkv.1 for ; Tue, 13 Sep 2016 07:59:57 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id z203si6098103ybz.113.2016.09.13.07.59.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Sep 2016 07:59:57 -0700 (PDT) Date: Tue, 13 Sep 2016 16:59:07 +0200 From: Oleg Nesterov Subject: Re: [PATCH v2] mm, proc: Fix region lost in /proc/self/smaps Message-ID: <20160913145906.GA28037@redhat.com> References: <1473649964-20191-1-git-send-email-guangrong.xiao@linux.intel.com> <20160912125447.GM14524@dhcp22.suse.cz> <57D6C332.4000409@intel.com> <20160912191035.GD14997@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160912191035.GD14997@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Dave Hansen , Xiao Guangrong , pbonzini@redhat.com, akpm@linux-foundation.org, dan.j.williams@intel.com, gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, stefanha@redhat.com, yuhuang@redhat.com, linux-mm@kvack.org, ross.zwisler@linux.intel.com On 09/12, Michal Hocko wrote: > > Considering how this all can be tricky and how partial reads can be > confusing and even misleading I am really wondering whether we > should simply document that only full reads will provide a sensible > results. I agree. I don't even understand why this was considered as a bug. Obviously, m_stop() which drops mmap_sep should not be called, or all the threads should be stopped, if you want to trust the result. Although all I can recall about this code is that it needs more cleanups. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org