From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: James Morse <james.morse@arm.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm, proc: Make the task_mmu walk_page_range() limit in clear_refs_write() obvious
Date: Thu, 1 Sep 2016 00:13:05 +0000 [thread overview]
Message-ID: <20160901001304.GA30002@hori1.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <1472655792-22439-1-git-send-email-james.morse@arm.com>
On Wed, Aug 31, 2016 at 04:03:12PM +0100, James Morse wrote:
> Trying to walk all of virtual memory requires architecture specific
> knowledge. On x86_64, addresses must be sign extended from bit 48,
> whereas on arm64 the top VA_BITS of address space have their own set
> of page tables.
>
> clear_refs_write() calls walk_page_range() on the range 0 to ~0UL, it
> provides a test_walk() callback that only expects to be walking over
> VMAs. Currently walk_pmd_range() will skip memory regions that don't
> have a VMA, reporting them as a hole.
>
> As this call only expects to walk user address space, make it walk
> 0 to 'highest_vm_end'.
>
> Signed-off-by: James Morse <james.morse@arm.com>
> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Makes sense to me.
Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-09-01 0:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 15:03 James Morse
2016-09-01 0:13 ` Naoya Horiguchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901001304.GA30002@hori1.linux.bs1.fc.nec.co.jp \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=james.morse@arm.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox