From: Reza Arbab <arbab@linux.vnet.ibm.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Yaowei Bai <baiyaowei@cmss.chinamobile.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Dan Williams <dan.j.williams@intel.com>,
Xishi Qiu <qiuxishi@huawei.com>,
David Vrabel <david.vrabel@citrix.com>,
Chen Yucong <slaoub@gmail.com>, Andrew Banman <abanman@sgi.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return value
Date: Wed, 31 Aug 2016 18:38:12 -0500 [thread overview]
Message-ID: <20160831233811.g6kf24fdhnfhn637@arbab-vm> (raw)
In-Reply-To: <alpine.DEB.2.10.1608311402520.33967@chino.kir.corp.google.com>
On Wed, Aug 31, 2016 at 02:06:14PM -0700, David Rientjes wrote:
>The correct fix is for store_mem_state() to return -EINVAL when
>device_online() returns non-zero.
Let me put it to you this way--which one of these sysfs operations is
behaving correctly?
# cd /sys/devices/system/memory/memory0
# cat online
1
# echo 1 > online; echo $?
0
or
# cd /sys/devices/system/memory/memory0
# cat state
online
# echo online > state; echo $?
-bash: echo: write error: Invalid argument
1
One of them should change to match the other.
--
Reza Arbab
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-08-31 23:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160831150105.GB26702@kroah.com>
2016-08-31 15:44 ` Reza Arbab
2016-08-31 20:25 ` Andrew Morton
2016-08-31 21:06 ` David Rientjes
2016-08-31 23:38 ` Reza Arbab [this message]
2016-09-01 0:03 ` David Rientjes
2016-09-01 0:17 ` Reza Arbab
2016-09-01 0:28 ` David Rientjes
2016-09-01 1:57 ` Reza Arbab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831233811.g6kf24fdhnfhn637@arbab-vm \
--to=arbab@linux.vnet.ibm.com \
--cc=abanman@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=baiyaowei@cmss.chinamobile.com \
--cc=dan.j.williams@intel.com \
--cc=david.vrabel@citrix.com \
--cc=gregkh@linuxfoundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=qiuxishi@huawei.com \
--cc=rientjes@google.com \
--cc=slaoub@gmail.com \
--cc=vbabka@suse.cz \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox