From: Andrew Morton <akpm@linux-foundation.org>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <david@fromorbit.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Jan Kara <jack@suse.com>,
linux-mm@kvack.org, linux-nvdimm@ml01.01.org,
Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [PATCH v2] mm: silently skip readahead for DAX inodes
Date: Wed, 24 Aug 2016 15:47:58 -0700 [thread overview]
Message-ID: <20160824154758.3bb6bbf66f8914f0e90c9183@linux-foundation.org> (raw)
In-Reply-To: <20160824221429.21158-1-ross.zwisler@linux.intel.com>
On Wed, 24 Aug 2016 16:14:29 -0600 Ross Zwisler <ross.zwisler@linux.intel.com> wrote:
> For DAX inodes we need to be careful to never have page cache pages in the
> mapping->page_tree. This radix tree should be composed only of DAX
> exceptional entries and zero pages.
>
> ltp's readahead02 test was triggering a warning because we were trying to
> insert a DAX exceptional entry but found that a page cache page had
> already been inserted into the tree. This page was being inserted into the
> radix tree in response to a readahead(2) call.
>
> Readahead doesn't make sense for DAX inodes, but we don't want it to report
> a failure either. Instead, we just return success and don't do any work.
>
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Reported-by: Jeff Moyer <jmoyer@redhat.com>
cc:stable [4.5+] ?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-08-24 22:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 20:37 [PATCH] " Ross Zwisler
2016-08-24 20:42 ` Andrew Morton
2016-08-24 22:14 ` [PATCH v2] " Ross Zwisler
2016-08-24 22:47 ` Andrew Morton [this message]
2016-08-25 16:42 ` [PATCH v2 RESEND] " Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160824154758.3bb6bbf66f8914f0e90c9183@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@fromorbit.com \
--cc=jack@suse.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox