From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f70.google.com (mail-lf0-f70.google.com [209.85.215.70]) by kanga.kvack.org (Postfix) with ESMTP id 676AD6B0038 for ; Tue, 23 Aug 2016 09:54:29 -0400 (EDT) Received: by mail-lf0-f70.google.com with SMTP id 33so97670443lfw.1 for ; Tue, 23 Aug 2016 06:54:29 -0700 (PDT) Received: from fireflyinternet.com (mail.fireflyinternet.com. [109.228.58.192]) by mx.google.com with ESMTPS id i4si3189025wjn.54.2016.08.23.06.54.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Aug 2016 06:54:28 -0700 (PDT) Date: Tue, 23 Aug 2016 14:54:24 +0100 From: Chris Wilson Subject: Re: [PATCH] io-mapping.h: s/PAGE_KERNEL_IO/PAGE_KERNEL/ Message-ID: <20160823135424.GA16402@nuc-i3427.alporthouse.com> References: <20160823072253.26977-1-chris@chris-wilson.co.uk> <1471939443.3696.2.camel@linux.intel.com> <20160823120518.GE10980@phenom.ffwll.local> <20160823122119.GK20834@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Daniel Vetter Cc: Joonas Lahtinen , intel-gfx , Linux MM On Tue, Aug 23, 2016 at 03:43:15PM +0200, Daniel Vetter wrote: > On Tue, Aug 23, 2016 at 2:21 PM, Chris Wilson wrote: > > On Tue, Aug 23, 2016 at 02:05:18PM +0200, Daniel Vetter wrote: > >> On Tue, Aug 23, 2016 at 11:04:03AM +0300, Joonas Lahtinen wrote: > >> > On ti, 2016-08-23 at 08:22 +0100, Chris Wilson wrote: > >> > > PAGE_KERNEL_IO is an x86-ism. Though it is used to define the pgprot_t > >> > > used for the iomapped region, it itself is just PAGE_KERNEL. On all > >> > > other arches, PAGE_KERNEL_IO is undefined so in a general header we must > >> > > refrain from using it. > >> > > > >> > > >> > There is; > >> > > >> > #define __PAGE_KERNEL_IO (__PAGE_KERNEL) > >> > > >> > So no functional change, but will compile on all archs. > >> > > >> > Reviewed-by: Joonas Lahtinen > >> > >> Still not happy: > >> > >> CC drivers/gpio/gpiolib-of.o > >> In file included from drivers/gpio/gpiolib-of.c:19:0: > >> ./include/linux/io-mapping.h: In function a??io_mapping_init_wca??: > >> ./include/linux/io-mapping.h:125:16: error: implicit declaration of function a??pgprot_writecombinea?? [-Werror=implicit-function-declaration] > >> iomap->prot = pgprot_writecombine(PAGE_KERNEL); > >> ^~~~~~~~~~~~~~~~~~~ > >> ./include/linux/io-mapping.h:125:36: error: a??PAGE_KERNELa?? undeclared (first use in this function) > >> iomap->prot = pgprot_writecombine(PAGE_KERNEL); > >> ^~~~~~~~~~~ > > > > That was pulled in by the x86 headers, > > > > #include > > Can you pls respin? Was that right? -Chris -- Chris Wilson, Intel Open Source Technology Centre -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org