From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Christoph Lameter <cl@linux.com>
Cc: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] mm/slab: Improve performance of gathering slabinfo stats
Date: Tue, 16 Aug 2016 12:03:14 +0900 [thread overview]
Message-ID: <20160816030314.GB16913@js1304-P5Q-DELUXE> (raw)
In-Reply-To: <alpine.DEB.2.20.1608050919410.27772@east.gentwo.org>
On Fri, Aug 05, 2016 at 09:21:56AM -0500, Christoph Lameter wrote:
> On Fri, 5 Aug 2016, Joonsoo Kim wrote:
>
> > If above my comments are fixed, all counting would be done with
> > holding a lock. So, atomic definition isn't needed for the SLAB.
>
> Ditto for slub. struct kmem_cache_node is alrady defined in mm/slab.h.
> Thus it is a common definition already and can be used by both.
>
> Making nr_slabs and total_objects unsigned long would be great.
In SLUB, nr_slabs is manipulated without holding a lock so atomic
operation should be used.
Anyway, Aruna. Could you handle my comment?
Thank.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-08-16 2:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 19:01 Aruna Ramakrishna
2016-08-04 21:06 ` Andrew Morton
2016-08-04 21:49 ` Aruna Ramakrishna
2016-08-05 0:35 ` Joonsoo Kim
2016-08-05 14:21 ` Christoph Lameter
2016-08-16 3:03 ` Joonsoo Kim [this message]
2016-08-16 15:52 ` Christoph Lameter
2016-08-17 7:13 ` aruna.ramakrishna
2016-08-17 14:36 ` Christoph Lameter
2016-08-05 14:17 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160816030314.GB16913@js1304-P5Q-DELUXE \
--to=iamjoonsoo.kim@lge.com \
--cc=akpm@linux-foundation.org \
--cc=aruna.ramakrishna@oracle.com \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox