[mmotm:master 70/106] arch/x86/kernel/process.c:511:9: error: implicit declaration of function 'randomize_page'

[mmotm:master 70/106] arch/x86/kernel/process.c:511:9: error: implicit declaration of function 'randomize_page'

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]

tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   304bec1b1d331282b76d92a1487902ce1f158337
commit: 216e0dbb5aab2e588b1f9de3b434015aa1c412f7 [70/106] x86: use simpler API for random address requests
config: i386-tinyconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        git checkout 216e0dbb5aab2e588b1f9de3b434015aa1c412f7
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: the mmotm/master HEAD 304bec1b1d331282b76d92a1487902ce1f158337 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   arch/x86/kernel/process.c: In function 'arch_randomize_brk':
>> arch/x86/kernel/process.c:511:9: error: implicit declaration of function 'randomize_page' [-Werror=implicit-function-declaration]
     return randomize_page(mm->brk, 0x02000000);
            ^~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/randomize_page +511 arch/x86/kernel/process.c

   505			sp -= get_random_int() % 8192;
   506		return sp & ~0xf;
   507	}
   508	
   509	unsigned long arch_randomize_brk(struct mm_struct *mm)
   510	{
 > 511		return randomize_page(mm->brk, 0x02000000);
   512	}
   513	
   514	/*

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 6373 bytes --]

Re: [mmotm:master 70/106] arch/x86/kernel/process.c:511:9: error: implicit declaration of function 'randomize_page'

[Jason Cooper]

Andrew, 

I think you have v1 and v2 of the randomize page patches in your stack. Could you drop v1 please?

thx,

Jason.

> On Aug 11, 2016, at 21:19, kbuild test robot <fengguang.wu@intel.com> wrote:
> 
> tree:   git://git.cmpxchg.org/linux-mmotm.git master
> head:   304bec1b1d331282b76d92a1487902ce1f158337
> commit: 216e0dbb5aab2e588b1f9de3b434015aa1c412f7 [70/106] x86: use simpler API for random address requests
> config: i386-tinyconfig (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
>        git checkout 216e0dbb5aab2e588b1f9de3b434015aa1c412f7
>        # save the attached .config to linux build tree
>        make ARCH=i386 
> 
> Note: the mmotm/master HEAD 304bec1b1d331282b76d92a1487902ce1f158337 builds fine.
>      It only hurts bisectibility.
> 
> All errors (new ones prefixed by >>):
> 
>   arch/x86/kernel/process.c: In function 'arch_randomize_brk':
>>> arch/x86/kernel/process.c:511:9: error: implicit declaration of function 'randomize_page' [-Werror=implicit-function-declaration]
>     return randomize_page(mm->brk, 0x02000000);
>            ^~~~~~~~~~~~~~
>   cc1: some warnings being treated as errors
> 
> vim +/randomize_page +511 arch/x86/kernel/process.c
> 
>   505            sp -= get_random_int() % 8192;
>   506        return sp & ~0xf;
>   507    }
>   508    
>   509    unsigned long arch_randomize_brk(struct mm_struct *mm)
>   510    {
>> 511        return randomize_page(mm->brk, 0x02000000);
>   512    }
>   513    
>   514    /*
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> <.config.gz>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [mmotm:master 70/106] arch/x86/kernel/process.c:511:9: error: implicit declaration of function 'randomize_page'

[Andrew Morton]

On Thu, 11 Aug 2016 21:31:15 -0400 Jason Cooper <jason@lakedaemon.net> wrote:

> Andrew, 
> 
> I think you have v1 and v2 of the randomize page patches in your stack. Could you drop v1 please?
> 

I have the v1 series and a series of deltas which turn that into v2.

I also see a v3 on the lists so I'm all confused.  Please triple-check
linux-next versus your latest version.

I can't reproduced this build error.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [mmotm:master 70/106] arch/x86/kernel/process.c:511:9: error: implicit declaration of function 'randomize_page'

[Jason Cooper]

On Mon, Aug 15, 2016 at 02:46:07PM -0700, Andrew Morton wrote:
> On Thu, 11 Aug 2016 21:31:15 -0400 Jason Cooper <jason@lakedaemon.net> wrote:
> > I think you have v1 and v2 of the randomize page patches in your stack. Could you drop v1 please?

I was wrong here.  The patches are mis-labelled.  The patches labelled
'v2' are deltas regressing to an older version of the series.

> I have the v1 series and a series of deltas which turn that into v2.
> 
> I also see a v3 on the lists so I'm all confused.  Please triple-check
> linux-next versus your latest version.

This is currently in akpm/next:

  9f60fb9385f5 random: remove unused randomize_range()
  81221b53ea05 unicore32-use-simpler-api-for-random-address-requests-v2
  6205f3d87280 unicore32: use simpler API for random address requests
  af8c36a0a66a tile-use-simpler-api-for-random-address-requests-v2
  18c80b9aa3a3 tile: use simpler API for random address requests
  742fffc5251b arm64-use-simpler-api-for-random-address-requests-v2
  f30c92be8d31 arm64: use simpler API for random address requests
  cbcb520687fd arm-use-simpler-api-for-random-address-requests-v2
  f39cdf6eca33 ARM: use simpler API for random address requests
  2f20ec82da2e x86-use-simpler-api-for-random-address-requests-v2
  c8923c663214 x86: use simpler API for random address requests
  027cac3e28bd random-simplify-api-for-random-address-requests-v2
  b990c09770d3 random: simplify API for random address requests

if you remove the patches that match /random-address-requests-v2$/, then
things should be good.  I've confirmed that

  b990c09770d3 random: simplify API for random address requests

is the proper version and that every other patch on top of that
correctly adds randomize_page().  It's the ones labelled 'v2' that are
reverting changes to an older version of the series (randomize_addr).

> I can't reproduced this build error.

It's a build failure that only occurs when a bisect would land in the
middle of the old series.  Removing the patches labelled v2 should fix
it.

Sorry for the confusion.

thx,

Jason.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>