From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f69.google.com (mail-pa0-f69.google.com [209.85.220.69]) by kanga.kvack.org (Postfix) with ESMTP id 57F7B6B0253 for ; Wed, 3 Aug 2016 04:29:22 -0400 (EDT) Received: by mail-pa0-f69.google.com with SMTP id ag5so342062253pad.2 for ; Wed, 03 Aug 2016 01:29:22 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id h70si7791704pfh.199.2016.08.03.01.29.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Aug 2016 01:29:21 -0700 (PDT) Date: Wed, 3 Aug 2016 10:29:35 +0200 From: Greg KH Subject: Re: [PATCH stable 4.6+] radix-tree: account nodes to memcg only if explicitly requested Message-ID: <20160803082935.GB32280@kroah.com> References: <1470141934-4568-1-git-send-email-vdavydov@virtuozzo.com> <20160803035139.GB31125@kroah.com> <20160803081525.GF13263@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160803081525.GF13263@esperanza> Sender: owner-linux-mm@kvack.org List-ID: To: Vladimir Davydov Cc: stable@vger.kernel.org, Johannes Weiner , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Wed, Aug 03, 2016 at 11:15:25AM +0300, Vladimir Davydov wrote: > On Wed, Aug 03, 2016 at 05:51:39AM +0200, Greg KH wrote: > > On Tue, Aug 02, 2016 at 03:45:34PM +0300, Vladimir Davydov wrote: > > > Radix trees may be used not only for storing page cache pages, so > > > unconditionally accounting radix tree nodes to the current memory cgroup > > > is bad: if a radix tree node is used for storing data shared among > > > different cgroups we risk pinning dead memory cgroups forever. So let's > > > only account radix tree nodes if it was explicitly requested by passing > > > __GFP_ACCOUNT to INIT_RADIX_TREE. Currently, we only want to account > > > page cache entries, so mark mapping->page_tree so. > > > > > > Signed-off-by: Vladimir Davydov > > > Acked-by: Johannes Weiner > > > Acked-by: Michal Hocko > > > Cc: [4.6+] > > > --- > > > fs/inode.c | 2 +- > > > lib/radix-tree.c | 14 ++++++++++---- > > > 2 files changed, 11 insertions(+), 5 deletions(-) > > > > Is this patch in Linus's tree already? > > Not yet, it should only be added to 4.8, so I shouldn't have sent this > (didn't know how patches are submitted to stable). Please ignore. Please read Documentation/stable_kernel_rules.txt, it should help answer this question (hint, you almost got it right...) thanks, greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org