From: Michal Hocko <mhocko@kernel.org>
To: akpm@linux-foundation.org
Cc: zhong jiang <zhongjiang@huawei.com>,
qiuxishi@huawei.com, vbabka@suse.cz, mm-commits@vger.kernel.org,
Mike Kravetz <mike.kravetz@oracle.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Mel Gorman <mgorman@suse.de>,
linux-mm@kvack.org
Subject: Re: + mm-hugetlb-fix-race-when-migrate-pages.patch added to -mm tree
Date: Mon, 1 Aug 2016 17:31:43 +0200 [thread overview]
Message-ID: <20160801153143.GN13544@dhcp22.suse.cz> (raw)
In-Reply-To: <579F64E1.8030707@huawei.com>
On Mon 01-08-16 23:04:01, zhong jiang wrote:
> On 2016/8/1 19:02, Michal Hocko wrote:
> > On Sat 30-07-16 14:33:18, zhong jiang wrote:
> >> On 2016/7/29 19:27, Michal Hocko wrote:
> >>> On Thu 21-07-16 09:43:40, Michal Hocko wrote:
> >>>> We have further discussed the patch and I believe it is not correct. See [1].
> >>>> I am proposing the following alternative.
> >>> Andrew, please drop the mm-hugetlb-fix-race-when-migrate-pages.patch. It
> >>> is clearly racy. Whether the BUG_ON update is really the right and
> >>> sufficient fix is not 100% clear yet and we are waiting for Zhong Jiang
> >>> testing.
> >> The issue is very hard to recur. Without attaching any patch to
> >> kernel code. up to now, it still not happens to it.
> > Hmm, OK. So what do you propose? Are you OK with the BUG_ON change or do
> > you think that this needs a deeper fix?
>
> yes, I agree with your change.
OK, Andrew, could you merge
http://lkml.kernel.org/r/20160721074340.GA26398@dhcp22.suse.cz with ack
from Naoya
http://lkml.kernel.org/r/20160721081355.GB25398@hori1.linux.bs1.fc.nec.co.jp
Thanks!
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-08-01 15:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <578eb28b.YbRUDGz5RloTVlrE%akpm@linux-foundation.org>
2016-07-21 7:43 ` Michal Hocko
2016-07-21 8:13 ` Naoya Horiguchi
2016-07-21 10:29 ` Michal Hocko
2016-07-21 10:54 ` zhong jiang
2016-07-21 11:27 ` Michal Hocko
2016-07-21 12:14 ` zhong jiang
2016-07-21 12:30 ` Michal Hocko
2016-07-21 12:45 ` zhong jiang
2016-07-21 12:55 ` Michal Hocko
2016-07-21 13:25 ` zhong jiang
2016-07-21 13:40 ` Michal Hocko
2016-07-21 13:58 ` zhong jiang
2016-07-21 14:01 ` Michal Hocko
2016-07-21 14:13 ` zhong jiang
2016-07-21 14:27 ` Michal Hocko
2016-07-21 14:33 ` zhong jiang
2016-07-22 7:17 ` Naoya Horiguchi
2016-07-26 7:58 ` Michal Hocko
2016-07-26 14:04 ` zhong jiang
2016-07-27 14:44 ` Michal Hocko
2016-07-29 11:27 ` Michal Hocko
2016-07-30 6:33 ` zhong jiang
2016-08-01 11:02 ` Michal Hocko
2016-08-01 15:04 ` zhong jiang
2016-08-01 15:31 ` Michal Hocko [this message]
[not found] <003701d1e328$202ca9d0$6085fd70$@alibaba-inc.com>
2016-07-21 8:19 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160801153143.GN13544@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mike.kravetz@oracle.com \
--cc=mm-commits@vger.kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=qiuxishi@huawei.com \
--cc=vbabka@suse.cz \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox