From: Michal Hocko <mhocko@kernel.org>
To: Vladimir Davydov <vdavydov@virtuozzo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@techsingularity.net>,
Hillf Danton <hillf.zj@alibaba-inc.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Vlastimil Babka <vbabka@suse.cz>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Minchan Kim <minchan@kernel.org>, Rik van Riel <riel@surriel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim
Date: Mon, 1 Aug 2016 15:27:04 +0200 [thread overview]
Message-ID: <20160801132703.GF13544@dhcp22.suse.cz> (raw)
In-Reply-To: <20160801132145.GA19395@esperanza>
On Mon 01-08-16 16:21:45, Vladimir Davydov wrote:
> On Mon, Aug 01, 2016 at 03:18:40PM +0200, Michal Hocko wrote:
> > On Mon 01-08-16 16:03:10, Vladimir Davydov wrote:
> > > We must call shrink_slab() for each memory cgroup on both global and
> > > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally
> > > changed that so that now shrink_slab() is only called with memcg != NULL
> > > on memcg reclaim. As a result, memcg-aware shrinkers (including
> > > dentry/inode) are never invoked on global reclaim. Fix that.
> > >
> > > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis")
> >
> > I guess you meant b2e18757f2c9. I do not see d71df22b55099 anywhere.
>
> I'm basing on top of v4.7-mmotm-2016-07-28-16-33 and there it's
> d71df22b55099.
But this sha is unstable. THe patch you are referring to is already
sitting in the Linus tree so please use his (stable sha instead).
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-08-01 13:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 13:03 Vladimir Davydov
2016-08-01 13:18 ` Michal Hocko
2016-08-01 13:21 ` Vladimir Davydov
2016-08-01 13:27 ` Michal Hocko [this message]
2016-08-01 15:15 ` Johannes Weiner
2016-08-02 0:11 ` Minchan Kim
2016-08-02 9:32 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160801132703.GF13544@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=minchan@kernel.org \
--cc=riel@surriel.com \
--cc=vbabka@suse.cz \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox