From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owner-linux-mm@kvack.org>
Received: from mail-it0-f70.google.com (mail-it0-f70.google.com [209.85.214.70])
	by kanga.kvack.org (Postfix) with ESMTP id 5093E6B0260
	for <linux-mm@kvack.org>; Mon,  1 Aug 2016 09:21:54 -0400 (EDT)
Received: by mail-it0-f70.google.com with SMTP id d65so10456620ith.0
        for <linux-mm@kvack.org>; Mon, 01 Aug 2016 06:21:54 -0700 (PDT)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00103.outbound.protection.outlook.com. [40.107.0.103])
        by mx.google.com with ESMTPS id r10si19328303oih.174.2016.08.01.06.21.53
        for <linux-mm@kvack.org>
        (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
        Mon, 01 Aug 2016 06:21:53 -0700 (PDT)
Date: Mon, 1 Aug 2016 16:21:45 +0300
From: Vladimir Davydov <vdavydov@virtuozzo.com>
Subject: Re: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on
 global reclaim
Message-ID: <20160801132145.GA19395@esperanza>
References: <1470056590-7177-1-git-send-email-vdavydov@virtuozzo.com>
 <20160801131840.GE13544@dhcp22.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20160801131840.GE13544@dhcp22.suse.cz>
Sender: owner-linux-mm@kvack.org
List-ID: <linux-mm.kvack.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mgorman@techsingularity.net>, Hillf Danton <hillf.zj@alibaba-inc.com>, Johannes Weiner <hannes@cmpxchg.org>, Vlastimil Babka <vbabka@suse.cz>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Minchan Kim <minchan@kernel.org>, Rik van Riel <riel@surriel.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org

On Mon, Aug 01, 2016 at 03:18:40PM +0200, Michal Hocko wrote:
> On Mon 01-08-16 16:03:10, Vladimir Davydov wrote:
> > We must call shrink_slab() for each memory cgroup on both global and
> > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally
> > changed that so that now shrink_slab() is only called with memcg != NULL
> > on memcg reclaim. As a result, memcg-aware shrinkers (including
> > dentry/inode) are never invoked on global reclaim. Fix that.
> > 
> > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis")
> 
> I guess you meant b2e18757f2c9. I do not see d71df22b55099 anywhere.

I'm basing on top of v4.7-mmotm-2016-07-28-16-33 and there it's
d71df22b55099.

> 
> > Signed-off-by: Vladimir Davydov <vdavydov@virtuozzo.com>
> 
> The fix looks ok to me otherwise
> 
> Acked-by: Michal Hocko <mhocko@suse.com>

Thanks!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>