From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f70.google.com (mail-wm0-f70.google.com [74.125.82.70]) by kanga.kvack.org (Postfix) with ESMTP id 3A3C96B0253 for ; Mon, 1 Aug 2016 07:02:09 -0400 (EDT) Received: by mail-wm0-f70.google.com with SMTP id o80so79753341wme.1 for ; Mon, 01 Aug 2016 04:02:09 -0700 (PDT) Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com. [74.125.82.66]) by mx.google.com with ESMTPS id jv2si30807647wjc.268.2016.08.01.04.02.05 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Aug 2016 04:02:05 -0700 (PDT) Received: by mail-wm0-f66.google.com with SMTP id i5so25648197wmg.2 for ; Mon, 01 Aug 2016 04:02:05 -0700 (PDT) Date: Mon, 1 Aug 2016 13:02:03 +0200 From: Michal Hocko Subject: Re: + mm-hugetlb-fix-race-when-migrate-pages.patch added to -mm tree Message-ID: <20160801110203.GB13544@dhcp22.suse.cz> References: <578eb28b.YbRUDGz5RloTVlrE%akpm@linux-foundation.org> <20160721074340.GA26398@dhcp22.suse.cz> <20160729112707.GB8031@dhcp22.suse.cz> <579C4A2E.4080009@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <579C4A2E.4080009@huawei.com> Sender: owner-linux-mm@kvack.org List-ID: To: zhong jiang Cc: akpm@linux-foundation.org, qiuxishi@huawei.com, vbabka@suse.cz, mm-commits@vger.kernel.org, Mike Kravetz , Naoya Horiguchi , Mel Gorman , linux-mm@kvack.org On Sat 30-07-16 14:33:18, zhong jiang wrote: > On 2016/7/29 19:27, Michal Hocko wrote: > > On Thu 21-07-16 09:43:40, Michal Hocko wrote: > >> We have further discussed the patch and I believe it is not correct. See [1]. > >> I am proposing the following alternative. > > Andrew, please drop the mm-hugetlb-fix-race-when-migrate-pages.patch. It > > is clearly racy. Whether the BUG_ON update is really the right and > > sufficient fix is not 100% clear yet and we are waiting for Zhong Jiang > > testing. > > The issue is very hard to recur. Without attaching any patch to > kernel code. up to now, it still not happens to it. Hmm, OK. So what do you propose? Are you OK with the BUG_ON change or do you think that this needs a deeper fix? -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org