From: Michal Hocko <mhocko@kernel.org>
To: Chen Gang <chengang@emindsoft.com.cn>
Cc: Andrew Morton <akpm@linux-foundation.org>,
vbabka@suse.cz, kirill.shutemov@linux.intel.com,
mingo@kernel.org, dave.hansen@linux.intel.com,
dan.j.williams@intel.com, hannes@cmpxchg.org, jack@suse.cz,
iamjoonsoo.kim@lge.com, jmarchan@redhat.com,
dingel@linux.vnet.ibm.com, oleg@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Chen Gang <gang.chen.5i5j@gmail.com>
Subject: Re: [PATCH] mm: gup: Re-define follow_page_mask output parameter page_mask usage
Date: Wed, 13 Jul 2016 09:50:24 +0200 [thread overview]
Message-ID: <20160713075024.GB28723@dhcp22.suse.cz> (raw)
In-Reply-To: <578522CE.9060905@emindsoft.com.cn>
On Wed 13-07-16 01:03:10, Chen Gang wrote:
> On 7/12/16 05:17, Andrew Morton wrote:
> > On Sun, 10 Jul 2016 01:17:05 +0800 chengang@emindsoft.com.cn wrote:
> >
> >> For a pure output parameter:
> >>
> >> - When callee fails, the caller should not assume the output parameter
> >> is still valid.
> >>
> >> - And callee should not assume the pure output parameter must be
> >> provided by caller -- caller has right to pass NULL when caller does
> >> not care about it.
> >
> > Sorry, I don't think this one is worth merging really.
> >
>
> OK, thanks, I can understand.
>
> It will be better if provide more details: e.g.
>
> - This patch is incorrect, or the comments is not correct.
>
> - The patch is worthless, at present.
I would say the patch is not really needed. The code you are touching
works just fine and there is no reason to touch it unless this is a part
of a larger change where future changes would be easier to
review/implement.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-07-13 7:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-09 17:17 chengang
2016-07-11 21:17 ` Andrew Morton
2016-07-12 17:03 ` Chen Gang
2016-07-13 7:50 ` Michal Hocko [this message]
2016-07-17 0:13 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160713075024.GB28723@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chengang@emindsoft.com.cn \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dingel@linux.vnet.ibm.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=jack@suse.cz \
--cc=jmarchan@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox