[linux-stable-rc:linux-3.14.y 4656/4802] drivers/media/i2c/s5k5baf.c:1053:10: warning: logical not is only applied to the left hand side of comparison

[kbuild test robot <fengguang.wu@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2808 bytes --]

Hi,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-3.14.y
head:   bd411c70884f51ef0ffa719c87a0a92197945cf1
commit: 3711edaf01a01818f2aed9f21efe29b9818134b9 [4656/4802] compiler-gcc: integrate the various compiler-gcc[345].h files
config: i386-randconfig-i1-201628 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        git checkout 3711edaf01a01818f2aed9f21efe29b9818134b9
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/media/i2c/s5k5baf.c: In function 's5k5baf_set_power':
>> drivers/media/i2c/s5k5baf.c:1053:10: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
     if (!on != state->power)
             ^~

vim +1053 drivers/media/i2c/s5k5baf.c

7d459937 Andrzej Hajda 2013-12-05  1037  
7d459937 Andrzej Hajda 2013-12-05  1038  	ret = s5k5baf_fw_parse(&c->dev, &state->fw, fw->size / 2,
7d459937 Andrzej Hajda 2013-12-05  1039  			       (u16 *)fw->data);
7d459937 Andrzej Hajda 2013-12-05  1040  
7d459937 Andrzej Hajda 2013-12-05  1041  	release_firmware(fw);
7d459937 Andrzej Hajda 2013-12-05  1042  
7d459937 Andrzej Hajda 2013-12-05  1043  	return ret;
7d459937 Andrzej Hajda 2013-12-05  1044  }
7d459937 Andrzej Hajda 2013-12-05  1045  
7d459937 Andrzej Hajda 2013-12-05  1046  static int s5k5baf_set_power(struct v4l2_subdev *sd, int on)
7d459937 Andrzej Hajda 2013-12-05  1047  {
7d459937 Andrzej Hajda 2013-12-05  1048  	struct s5k5baf *state = to_s5k5baf(sd);
7d459937 Andrzej Hajda 2013-12-05  1049  	int ret = 0;
7d459937 Andrzej Hajda 2013-12-05  1050  
7d459937 Andrzej Hajda 2013-12-05  1051  	mutex_lock(&state->lock);
7d459937 Andrzej Hajda 2013-12-05  1052  
7d459937 Andrzej Hajda 2013-12-05 @1053  	if (!on != state->power)
7d459937 Andrzej Hajda 2013-12-05  1054  		goto out;
7d459937 Andrzej Hajda 2013-12-05  1055  
7d459937 Andrzej Hajda 2013-12-05  1056  	if (on) {
7d459937 Andrzej Hajda 2013-12-05  1057  		if (state->fw == NULL)
7d459937 Andrzej Hajda 2013-12-05  1058  			s5k5baf_load_setfile(state);
7d459937 Andrzej Hajda 2013-12-05  1059  
7d459937 Andrzej Hajda 2013-12-05  1060  		s5k5baf_initialize_data(state);
7d459937 Andrzej Hajda 2013-12-05  1061  		ret = s5k5baf_power_on(state);

:::::: The code at line 1053 was first introduced by commit
:::::: 7d459937dc09bb8e448d9985ec4623779427d8a5 [media] Add driver for Samsung S5K5BAF camera sensor

:::::: TO: Andrzej Hajda <a.hajda@samsung.com>
:::::: CC: Mauro Carvalho Chehab <m.chehab@samsung.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 18835 bytes --]