Re: [PATCH 5/8] mm,oom: Remove unused signal_struct->oom_victims.

[Michal Hocko <mhocko@suse.cz>]

On Sun 03-07-16 11:40:03, Tetsuo Handa wrote:
> >From e2e22cd0c0c486d1aef01232fcc62b00fb01709f Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Date: Sat, 2 Jul 2016 23:02:19 +0900
> Subject: [PATCH 5/8] mm,oom: Remove unused signal_struct->oom_victims.
> 
> Since OOM_SCAN_ABORT case was removed, we no longer need to use
> signal_struct->oom_victims useless. Remove it.

I would squash this one into the previous.

> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> ---
>  include/linux/sched.h | 1 -
>  mm/oom_kill.c         | 2 --
>  2 files changed, 3 deletions(-)
> 
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index 553af29..f472f27 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -671,7 +671,6 @@ struct signal_struct {
>  	atomic_t		sigcnt;
>  	atomic_t		live;
>  	int			nr_threads;
> -	atomic_t oom_victims; /* # of TIF_MEDIE threads in this thread group */
>  	struct list_head	thread_head;
>  
>  	wait_queue_head_t	wait_chldexit;	/* for wait4() */
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index 734378a..55e0ffb 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -659,7 +659,6 @@ void mark_oom_victim(struct task_struct *tsk, struct oom_control *oc)
>  	/* OOM killer might race with memcg OOM */
>  	if (test_and_set_tsk_thread_flag(tsk, TIF_MEMDIE))
>  		return;
> -	atomic_inc(&tsk->signal->oom_victims);
>  	/*
>  	 * Since mark_oom_victim() is called from multiple threads,
>  	 * connect this mm to oom_mm_list only if not yet connected.
> @@ -693,7 +692,6 @@ void exit_oom_victim(struct task_struct *tsk)
>  {
>  	if (!test_and_clear_tsk_thread_flag(tsk, TIF_MEMDIE))
>  		return;
> -	atomic_dec(&tsk->signal->oom_victims);
>  
>  	if (!atomic_dec_return(&oom_victims))
>  		wake_up_all(&oom_victims_wait);
> -- 
> 1.8.3.1

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>