linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: linux-mm@kvack.org
Cc: akpm@linux-foundation.org, oleg@redhat.com, rientjes@google.com,
	vdavydov@parallels.com, mst@redhat.com, mhocko@suse.com,
	mhocko@kernel.org
Subject: [PATCH 5/8] mm,oom: Remove unused signal_struct->oom_victims.
Date: Sun, 3 Jul 2016 11:40:03 +0900	[thread overview]
Message-ID: <201607031140.GAF05212.tMFJFOOSLOQHVF@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <201607031135.AAH95347.MVOHQtFJFLOOFS@I-love.SAKURA.ne.jp>

>From e2e22cd0c0c486d1aef01232fcc62b00fb01709f Mon Sep 17 00:00:00 2001
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Date: Sat, 2 Jul 2016 23:02:19 +0900
Subject: [PATCH 5/8] mm,oom: Remove unused signal_struct->oom_victims.

Since OOM_SCAN_ABORT case was removed, we no longer need to use
signal_struct->oom_victims useless. Remove it.

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
---
 include/linux/sched.h | 1 -
 mm/oom_kill.c         | 2 --
 2 files changed, 3 deletions(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index 553af29..f472f27 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -671,7 +671,6 @@ struct signal_struct {
 	atomic_t		sigcnt;
 	atomic_t		live;
 	int			nr_threads;
-	atomic_t oom_victims; /* # of TIF_MEDIE threads in this thread group */
 	struct list_head	thread_head;
 
 	wait_queue_head_t	wait_chldexit;	/* for wait4() */
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index 734378a..55e0ffb 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -659,7 +659,6 @@ void mark_oom_victim(struct task_struct *tsk, struct oom_control *oc)
 	/* OOM killer might race with memcg OOM */
 	if (test_and_set_tsk_thread_flag(tsk, TIF_MEMDIE))
 		return;
-	atomic_inc(&tsk->signal->oom_victims);
 	/*
 	 * Since mark_oom_victim() is called from multiple threads,
 	 * connect this mm to oom_mm_list only if not yet connected.
@@ -693,7 +692,6 @@ void exit_oom_victim(struct task_struct *tsk)
 {
 	if (!test_and_clear_tsk_thread_flag(tsk, TIF_MEMDIE))
 		return;
-	atomic_dec(&tsk->signal->oom_victims);
 
 	if (!atomic_dec_return(&oom_victims))
 		wake_up_all(&oom_victims_wait);
-- 
1.8.3.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2016-07-03  2:40 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-03  2:35 [PATCH 0/8] Change OOM killer to use list of mm_struct Tetsuo Handa
2016-07-03  2:36 ` [PATCH 1/8] mm,oom_reaper: Remove pointless kthread_run() failure check Tetsuo Handa
2016-07-03 12:42   ` Oleg Nesterov
2016-07-03 16:03     ` Tetsuo Handa
2016-07-03 17:10       ` Oleg Nesterov
2016-07-03 21:53         ` Tetsuo Handa
2016-07-04 11:13           ` Oleg Nesterov
2016-07-07 11:14           ` Michal Hocko
2016-07-03  2:37 ` [PATCH 2/8] mm,oom_reaper: Reduce find_lock_task_mm() usage Tetsuo Handa
2016-07-07 11:19   ` Michal Hocko
2016-07-03  2:38 ` [PATCH 3/8] mm,oom: Use list of mm_struct used by OOM victims Tetsuo Handa
2016-07-04 10:39   ` Oleg Nesterov
2016-07-04 12:50     ` Tetsuo Handa
2016-07-04 18:25       ` Oleg Nesterov
2016-07-05 10:43         ` Tetsuo Handa
2016-07-05 20:52           ` Oleg Nesterov
2016-07-06  8:53             ` Oleg Nesterov
2016-07-06 11:43               ` Tetsuo Handa
2016-07-07 11:31   ` Michal Hocko
2016-07-03  2:39 ` [PATCH 4/8] mm,oom: Remove OOM_SCAN_ABORT case Tetsuo Handa
2016-07-03  2:40 ` Tetsuo Handa [this message]
2016-07-07 14:03   ` [PATCH 5/8] mm,oom: Remove unused signal_struct->oom_victims Michal Hocko
2016-07-03  2:40 ` [PATCH 6/8] mm,oom_reaper: Stop clearing TIF_MEMDIE on remote thread Tetsuo Handa
2016-07-07 14:06   ` Michal Hocko
2016-07-07 16:10     ` Tetsuo Handa
2016-07-07 16:54       ` Michal Hocko
2016-07-03  2:41 ` [PATCH 7/8] mm,oom_reaper: Pass OOM victim's comm and pid values via mm_struct Tetsuo Handa
2016-07-03  2:41 ` [PATCH 8/8] mm,oom_reaper: Make OOM reaper use list of mm_struct Tetsuo Handa
2016-07-04 10:40   ` Oleg Nesterov
2016-07-07 14:15   ` Michal Hocko
2016-07-07 11:04 ` [PATCH 0/8] Change OOM killer to " Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201607031140.GAF05212.tMFJFOOSLOQHVF@I-love.SAKURA.ne.jp \
    --to=penguin-kernel@i-love.sakura.ne.jp \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mhocko@suse.com \
    --cc=mst@redhat.com \
    --cc=oleg@redhat.com \
    --cc=rientjes@google.com \
    --cc=vdavydov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox