From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f200.google.com (mail-lb0-f200.google.com [209.85.217.200]) by kanga.kvack.org (Postfix) with ESMTP id 28CB36B025E for ; Mon, 20 Jun 2016 15:52:35 -0400 (EDT) Received: by mail-lb0-f200.google.com with SMTP id na2so32608024lbb.1 for ; Mon, 20 Jun 2016 12:52:35 -0700 (PDT) Received: from gum.cmpxchg.org (gum.cmpxchg.org. [85.214.110.215]) by mx.google.com with ESMTPS id u6si15870068wjv.222.2016.06.20.12.52.33 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jun 2016 12:52:33 -0700 (PDT) Date: Mon, 20 Jun 2016 15:50:01 -0400 From: Johannes Weiner Subject: Re: [PATCH] memcg: mem_cgroup_migrate() may be called with irq disabled Message-ID: <20160620195001.GA19775@cmpxchg.org> References: <5767CFE5.7080904@de.ibm.com> <20160620184158.GO3262@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160620184158.GO3262@mtj.duckdns.org> Sender: owner-linux-mm@kvack.org List-ID: To: Tejun Heo Cc: Andrew Morton , Michal Hocko , Vladimir Davydov , Linux MM , cgroups@vger.kernel.org, "linux-kernel@vger.kernel.org >> Linux Kernel Mailing List" , Christian Borntraeger , kernel-team@fb.com On Mon, Jun 20, 2016 at 02:41:58PM -0400, Tejun Heo wrote: > mem_cgroup_migrate() uses local_irq_disable/enable() but can be called > with irq disabled from migrate_page_copy(). This ends up enabling irq > while holding a irq context lock triggering the following lockdep > warning. Fix it by using irq_save/restore instead. Acked-by: Johannes Weiner Fixes: 74485cf2bc85 ("mm: migrate: consolidate mem_cgroup_migrate() calls") CC: stable@vger.kernel.org # 4.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org