From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f69.google.com (mail-it0-f69.google.com [209.85.214.69]) by kanga.kvack.org (Postfix) with ESMTP id 9FF166B0253 for ; Fri, 17 Jun 2016 03:25:39 -0400 (EDT) Received: by mail-it0-f69.google.com with SMTP id z189so160462418itg.2 for ; Fri, 17 Jun 2016 00:25:39 -0700 (PDT) Received: from lgeamrelo11.lge.com (LGEAMRELO11.lge.com. [156.147.23.51]) by mx.google.com with ESMTP id 75si13003831itu.78.2016.06.17.00.25.38 for ; Fri, 17 Jun 2016 00:25:39 -0700 (PDT) Date: Fri, 17 Jun 2016 16:27:53 +0900 From: Joonsoo Kim Subject: Re: [PATCH v2 1/7] mm/compaction: split freepages without holding the zone lock Message-ID: <20160617072752.GB810@js1304-P5Q-DELUXE> References: <1464230275-25791-1-git-send-email-iamjoonsoo.kim@lge.com> <575F1813.4020700@oracle.com> <20160614055257.GA13753@js1304-P5Q-DELUXE> <5760569D.6030907@oracle.com> <20160615022731.GB19863@js1304-P5Q-DELUXE> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160615022731.GB19863@js1304-P5Q-DELUXE> Sender: owner-linux-mm@kvack.org List-ID: To: Sasha Levin Cc: Andrew Morton , Vlastimil Babka , mgorman@techsingularity.net, Minchan Kim , Alexander Potapenko , Hugh Dickins , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Wed, Jun 15, 2016 at 11:27:31AM +0900, Joonsoo Kim wrote: > On Tue, Jun 14, 2016 at 03:10:21PM -0400, Sasha Levin wrote: > > On 06/14/2016 01:52 AM, Joonsoo Kim wrote: > > > On Mon, Jun 13, 2016 at 04:31:15PM -0400, Sasha Levin wrote: > > >> > On 05/25/2016 10:37 PM, js1304@gmail.com wrote: > > >>> > > From: Joonsoo Kim > > >>> > > > > >>> > > We don't need to split freepages with holding the zone lock. It will cause > > >>> > > more contention on zone lock so not desirable. > > >>> > > > > >>> > > Signed-off-by: Joonsoo Kim > > >> > > > >> > Hey Joonsoo, > > > Hello, Sasha. > > >> > > > >> > I'm seeing the following corruption/crash which seems to be related to > > >> > this patch: > > > Could you tell me why you think that following corruption is related > > > to this patch? list_del() in __isolate_free_page() is unchanged part. > > > > > > Before this patch, we did it by split_free_page() -> > > > __isolate_free_page() -> list_del(). With this patch, we do it by > > > calling __isolate_free_page() directly. > > > > I haven't bisected it, but it's the first time I see this issue and this > > commit seems to have done related changes that might cause this. > > > > I can go ahead with bisection if you don't think it's related. > > Hmm... I can't find a bug in this patch for now. There are more candidates > on this area hat changed by me and it would be very helpful if you can > do bisection. Hello, Sasha. You are right! Minchan found the bug in this patch! I will send updated patch soon. http://marc.info/?i=20160616100932.GS17127%40bbox Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org