From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
mgorman@techsingularity.net, Minchan Kim <minchan@kernel.org>,
Alexander Potapenko <glider@google.com>,
Hugh Dickins <hughd@google.com>, Michal Hocko <mhocko@kernel.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 1/7] mm/compaction: split freepages without holding the zone lock
Date: Wed, 15 Jun 2016 11:27:31 +0900 [thread overview]
Message-ID: <20160615022731.GB19863@js1304-P5Q-DELUXE> (raw)
In-Reply-To: <5760569D.6030907@oracle.com>
On Tue, Jun 14, 2016 at 03:10:21PM -0400, Sasha Levin wrote:
> On 06/14/2016 01:52 AM, Joonsoo Kim wrote:
> > On Mon, Jun 13, 2016 at 04:31:15PM -0400, Sasha Levin wrote:
> >> > On 05/25/2016 10:37 PM, js1304@gmail.com wrote:
> >>> > > From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> >>> > >
> >>> > > We don't need to split freepages with holding the zone lock. It will cause
> >>> > > more contention on zone lock so not desirable.
> >>> > >
> >>> > > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> >> >
> >> > Hey Joonsoo,
> > Hello, Sasha.
> >> >
> >> > I'm seeing the following corruption/crash which seems to be related to
> >> > this patch:
> > Could you tell me why you think that following corruption is related
> > to this patch? list_del() in __isolate_free_page() is unchanged part.
> >
> > Before this patch, we did it by split_free_page() ->
> > __isolate_free_page() -> list_del(). With this patch, we do it by
> > calling __isolate_free_page() directly.
>
> I haven't bisected it, but it's the first time I see this issue and this
> commit seems to have done related changes that might cause this.
>
> I can go ahead with bisection if you don't think it's related.
Hmm... I can't find a bug in this patch for now. There are more candidates
on this area hat changed by me and it would be very helpful if you can
do bisection.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-06-15 2:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 2:37 js1304
2016-05-26 2:37 ` [PATCH v2 2/7] mm/page_owner: initialize page owner " js1304
2016-06-03 10:23 ` Vlastimil Babka
2016-06-03 12:47 ` Joonsoo Kim
2016-06-06 15:20 ` Vlastimil Babka
2016-05-26 2:37 ` [PATCH v2 3/7] mm/page_owner: copy last_migrate_reason in copy_page_owner() js1304
2016-06-06 13:31 ` Vlastimil Babka
2016-05-26 2:37 ` [PATCH v2 4/7] mm/page_owner: introduce split_page_owner and replace manual handling js1304
2016-05-26 2:37 ` [PATCH v2 5/7] tools/vm/page_owner: increase temporary buffer size js1304
2016-05-26 2:37 ` [PATCH v2 6/7] mm/page_owner: use stackdepot to store stacktrace js1304
2016-06-06 13:56 ` Michal Hocko
2016-06-17 7:25 ` Joonsoo Kim
2016-06-17 9:55 ` Michal Hocko
2016-06-20 6:58 ` Joonsoo Kim
2016-06-06 14:51 ` Vlastimil Babka
2016-06-20 13:04 ` Alexander Potapenko
2016-05-26 2:37 ` [PATCH v2 7/7] mm/page_alloc: introduce post allocation processing on page allocator js1304
2016-06-06 15:21 ` Vlastimil Babka
2016-06-17 7:55 ` Joonsoo Kim
2016-06-03 10:10 ` [PATCH v2 1/7] mm/compaction: split freepages without holding the zone lock Vlastimil Babka
2016-06-03 12:45 ` Joonsoo Kim
2016-06-06 15:19 ` Vlastimil Babka
2016-06-13 20:31 ` Sasha Levin
2016-06-14 5:52 ` Joonsoo Kim
2016-06-14 19:10 ` Sasha Levin
2016-06-15 2:27 ` Joonsoo Kim [this message]
2016-06-17 7:27 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615022731.GB19863@js1304-P5Q-DELUXE \
--to=iamjoonsoo.kim@lge.com \
--cc=akpm@linux-foundation.org \
--cc=glider@google.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=sasha.levin@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox