From: Michal Hocko <mhocko@kernel.org>
To: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Cc: linux-mm@kvack.org, hughd@google.com, riel@redhat.com,
akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
n-horiguchi@ah.jp.nec.com, aarcange@redhat.com,
iamjoonsoo.kim@lge.com, gorcunov@openvz.org,
linux-kernel@vger.kernel.org, mgorman@suse.de,
rientjes@google.com, vbabka@suse.cz,
aneesh.kumar@linux.vnet.ibm.com, hannes@cmpxchg.org,
boaz@plexistor.com
Subject: Re: [PATCH 0/3] mm, thp: remove duplication and fix locking issues in swapin
Date: Mon, 13 Jun 2016 15:55:02 +0200 [thread overview]
Message-ID: <20160613135502.GI6518@dhcp22.suse.cz> (raw)
In-Reply-To: <20160611192106.GA6662@debian>
On Sat 11-06-16 22:21:06, Ebru Akagunduz wrote:
> On Fri, May 27, 2016 at 03:12:47PM +0200, Michal Hocko wrote:
[...]
> > IMHO we should drop the current ALLOCSTALL heuristic and replace it with
> > ~__GFP_DIRECT_RECLAIM.
>
> Actually, I don't lean towards to touch do_swap_page giving gfp parameter.
> do_swap_page is also used by do_page_fault, it can cause many side effect
> that I can't see.
The point of the patch is to keep the current gfp mask from all places
except for the optimistic swapin. This was what my example patch did
AFAIR.
> I've just sent a patch series for converting from optimistic to
> conservative and take back allocstall. Maybe that way can be easier to
> be approved and less problemitical.
I will try to have a look but I will be travelling this week so cannot
promise anything.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-06-13 13:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 17:14 Ebru Akagunduz
2016-05-23 17:14 ` [PATCH 1/3] mm, thp: remove duplication of included header Ebru Akagunduz
2016-05-23 17:14 ` [PATCH 2/3] mm, thp: fix possible circular locking dependency caused by sum_vm_event() Ebru Akagunduz
2016-05-23 17:14 ` [PATCH 3/3] mm, thp: make swapin readahead under down_read of mmap_sem Ebru Akagunduz
2016-05-23 17:44 ` Kirill A. Shutemov
2016-05-23 18:42 ` Michal Hocko
2016-05-23 18:49 ` Rik van Riel
2016-05-23 19:01 ` Kirill A. Shutemov
2016-05-23 19:26 ` Rik van Riel
2016-05-23 20:02 ` Kirill A. Shutemov
2016-05-23 20:13 ` Rik van Riel
2016-05-23 21:49 ` Kirill A. Shutemov
2016-05-23 23:08 ` Andrea Arcangeli
2016-05-23 17:29 ` [PATCH 0/3] mm, thp: remove duplication and fix locking issues in swapin Ebru Akagunduz
2016-05-27 13:12 ` Michal Hocko
2016-06-11 19:21 ` Ebru Akagunduz
2016-06-13 13:55 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613135502.GI6518@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=boaz@plexistor.com \
--cc=ebru.akagunduz@gmail.com \
--cc=gorcunov@openvz.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox