From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
roy.qing.li@gmail.com, vdavydov@virtuozzo.com
Subject: Re: [PATCH] mm: memcontrol: remove BUG_ON in uncharge_list
Date: Wed, 8 Jun 2016 10:58:33 -0400 [thread overview]
Message-ID: <20160608145833.GA6727@cmpxchg.org> (raw)
In-Reply-To: <20160608072554.GD22570@dhcp22.suse.cz>
On Wed, Jun 08, 2016 at 09:25:54AM +0200, Michal Hocko wrote:
> On Wed 08-06-16 15:00:48, roy.qing.li@gmail.com wrote:
> > From: Li RongQing <roy.qing.li@gmail.com>
> >
> > when call uncharge_list, if a page is transparent huge, and not need to
> > BUG_ON about non-transparent huge, since nobody should be be seeing the
> > page at this stage and this page cannot be raced with a THP split up
>
> Johannes do you remember why you have kept this bug on even after
> 0a31bc97c80c ("mm: memcontrol: rewrite uncharge API")?
No, I just copied it over without thinking too much about it. That
patch was pretty drastic, so why not keep the sanity checks in case
one of the many assumptions it made were flawed...
But it's probably okay to drop it at this point.
> > Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-06-08 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 7:00 roy.qing.li
2016-06-08 7:25 ` Michal Hocko
2016-06-08 14:58 ` Johannes Weiner [this message]
2016-06-08 15:06 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608145833.GA6727@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=cgroups@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=roy.qing.li@gmail.com \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox