From: Ingo Molnar <mingo@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, bugzilla-daemon@bugzilla.kernel.org,
jp.pozzi@izzop.net, Ingo Molnar <mingo@elte.hu>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [Bug 119641] New: hugetlbfs: disabling because there are no supported hugepage sizes
Date: Wed, 8 Jun 2016 10:42:41 +0200 [thread overview]
Message-ID: <20160608084241.GA10729@gmail.com> (raw)
In-Reply-To: <20160606140123.bbc4b06d0f9d8b974f7b323f@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> wrote:
>
> (switched to email. Please respond via emailed reply-to-all, not via the
> bugzilla web interface).
>
> Does anyone have any theories about this? I went through the
> 4.5.2->4.5.5 changelog searching for "huget" but came up blank..
>
> I'm suspiciously staring at Ingo's change
>
> commit b2eafe890d4a09bfa63ab31ff018d7d6bb8cfefc
> Merge: abfb949 ea5dfb5
> Author: Ingo Molnar <mingo@kernel.org>
> AuthorDate: Fri Apr 22 10:12:19 2016 +0200
> Commit: Ingo Molnar <mingo@kernel.org>
> CommitDate: Fri Apr 22 10:13:53 2016 +0200
>
> Merge branch 'x86/urgent' into x86/asm, to fix semantic conflict
>
> 'cpu_has_pse' has changed to boot_cpu_has(X86_FEATURE_PSE), fix this
> up in the merge commit when merging the x86/urgent tree that includes
> the following commit:
>
> 103f6112f253 ("x86/mm/xen: Suppress hugetlbfs in PV guests")
>
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
>
> --- a/arch/x86/include/asm/hugetlb.h
> +++ b/arch/x86/include/asm/hugetlb.h
> @@@ -4,6 -4,7 +4,7 @@@
> #include <asm/page.h>
> #include <asm-generic/hugetlb.h>
>
> -#define hugepages_supported() cpu_has_pse
> ++#define hugepages_supported() boot_cpu_has(X86_FEATURE_PSE)
That's really a no-op change, as we simply got rid of cpu_has_pse:
-#define cpu_has_pse boot_cpu_has(X86_FEATURE_PSE)
... and open coded the boot_cpu_has(X86_FEATURE_PSE) uses. There should be zero
change to the generated code.
Thanks,
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-06-08 8:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-119641-27@https.bugzilla.kernel.org/>
2016-06-06 21:01 ` Andrew Morton
2016-06-07 6:43 ` Jan Beulich
2016-06-08 8:42 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608084241.GA10729@gmail.com \
--to=mingo@kernel.org \
--cc=JBeulich@suse.com \
--cc=akpm@linux-foundation.org \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=jp.pozzi@izzop.net \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox